fix: merging dev to main branch#491
Merged
Prajwal-Microsoft merged 7 commits intomainfrom Nov 3, 2025
Merged
Conversation
…irtual network module
fix: Optimize the network module for DKM
Prajwal-Microsoft
approved these changes
Nov 3, 2025
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
networkmodule with a more modular approach using a dedicatedvirtualNetworkmodule, and direct AVM modules for Bastion Host and Jumpbox VM. As a result, all references to subnets and resource IDs are now sourced from the outputs of the newvirtualNetworkmodule, and the legacynetwork.bicepandbastionHost.bicepmodules are removed. This improves maintainability, clarity, and aligns the codebase with Azure best practices for modular infrastructure.Network architecture refactor:
networkmodule with a newvirtualNetworkmodule ininfra/main.bicep, updating all subnet and resource ID references to use outputs fromvirtualNetworkinstead ofnetwork.infra/modules/network.bicepandinfra/modules/network/bastionHost.bicep, eliminating legacy network and Bastion host logic. [1] [2]Private endpoint subnet references update:
virtualNetwork!.outputs.pepsSubnetResourceIdinstead ofnetwork!.outputs.subnetPrivateEndpointsResourceId. [1] [2] [3] [4] [5] [6] [7]AKS subnet reference update:
virtualNetwork!.outputs.webSubnetResourceIdinstead ofnetwork!.outputs.subnetWebResourceId, ensuring dedicated subnet usage and avoiding delegation conflicts.Private DNS zone and output fixes:
virtualNetwork!.outputs.resourceIdforvirtualNetworkResourceIdreferences.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information