Merged
Conversation
Roopan-Microsoft
approved these changes
Jan 5, 2026
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request enhances the end-to-end testing utilities for the Document Knowledge Mining (DKM) application by improving the
DkmPagepage object with new selectors and helper methods, and by adding robust screenshot capture on test failures to the test configuration. These changes aim to make the tests more reliable, maintainable, and easier to debug.Enhancements to DKM Page Object:
DkmPage, including support for file uploads, clearing filters/search, and improved handling of modal dialogs. This includes methods likeclick_upload_button,upload_file,upload_multiple_files,click_clear_all, and dialog handling withclose_dialog_if_open. [1] [2]ASK_QUESTIONandSEND_BUTTONto target the correct elements when multiple matches exist, reducing test flakiness. [1] [2]Test Infrastructure Improvements:
conftest.py, saving images to ascreenshotsdirectory and attaching them to the pytest HTML report for easier debugging. The screenshot logic is robust, handling both normal and setup phase errors. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information