Skip to content

chore: dev to main#530

Merged
Roopan-Microsoft merged 2 commits intomainfrom
dev
Jan 5, 2026
Merged

chore: dev to main#530
Roopan-Microsoft merged 2 commits intomainfrom
dev

Conversation

@NirajC-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

This pull request enhances the end-to-end testing utilities for the Document Knowledge Mining (DKM) application by improving the DkmPage page object with new selectors and helper methods, and by adding robust screenshot capture on test failures to the test configuration. These changes aim to make the tests more reliable, maintainable, and easier to debug.

Enhancements to DKM Page Object:

  • Added new selectors and utility methods to DkmPage, including support for file uploads, clearing filters/search, and improved handling of modal dialogs. This includes methods like click_upload_button, upload_file, upload_multiple_files, click_clear_all, and dialog handling with close_dialog_if_open. [1] [2]
  • Improved selector specificity for ASK_QUESTION and SEND_BUTTON to target the correct elements when multiple matches exist, reducing test flakiness. [1] [2]
  • Updated key interactions (e.g., entering questions, clicking send, selecting checkboxes) to first close any open dialogs, ensuring consistent test behavior even when modals are present. [1] [2] [3]

Test Infrastructure Improvements:

  • Implemented automatic screenshot capture on test failures in conftest.py, saving images to a screenshots directory and attaching them to the pytest HTML report for easier debugging. The screenshot logic is robust, handling both normal and setup phase errors. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 094761c into main Jan 5, 2026
6 of 8 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants