Fixed the reliability code quality issues

Author: Prekshith-Microsoft

src/backend/api/api_routes.py

@@ -279,6 +279,7 @@ async def batch_status_updates(
             try:
                 await websocket.receive_text()
             except asyncio.TimeoutError:
+                # TimeoutError is ignored to keep the WebSocket connection open without receiving data
                 pass
 
     except WebSocketDisconnect:

src/backend/common/services/batch_service.py

@@ -175,6 +175,8 @@ async def delete_batch(self, batch_id: UUID, user_id: str):
 
             self.logger.info(f"Successfully deleted batch with ID: {batch_id}")
             return {"message": "Batch deleted successfully", "batch_id": str(batch_id)}
+        else:
+            return {"message": "Batch not found", "batch_id": str(batch_id)}
 
     async def delete_file(self, file_id: UUID, user_id: str):
         """Delete a file and its logs, and update batch file count."""

src/backend/sql_agents/helpers/comms_manager.py

@@ -79,6 +79,8 @@ async def select_agent(self, agents, history):
                         ),
                         None,
                     )
+            # No matching case found, so explicitly return None
+            return None
 
     # class for termination strategy
     class ApprovalTerminationStrategy(TerminationStrategy):

src/frontend/src/api/utils.tsx

@@ -414,7 +414,7 @@ export const renderErrorSection = (batchSummary, expandedSections, setExpandedSe
 
 export const renderErrorContent = (batchSummary) => {
   // Group errors by file
-  const errorFiles = batchSummary.files.filter(file => file.error_count && file.error_count);
+  const errorFiles = batchSummary.files.filter(file => file.error_count);
   if (errorFiles.length === 0) {
     return (
       <div className={useStyles().errorItem}>

src/frontend/src/pages/batchView.tsx

@@ -349,7 +349,7 @@ const BatchStoryPage = () => {
     }
 
     // Show the summary page when summary is selected
-    if (selectedFile.id === "summary" && batchSummary) {
+    if (selectedFile.id === "summary") {
       // Check if there are no errors and all files are processed successfully
       const noErrors = (batchSummary.error_count === 0);
       const allFilesProcessed = (batchSummary.completed_files === batchSummary.total_files);

src/frontend/src/pages/modernizationPage.tsx

@@ -1244,7 +1244,7 @@ useEffect(() => {
     }
 
     // Show the full summary page only when all files are completed and summary is selected
-    if (allFilesCompleted && selectedFile?.id === "summary") {
+    if (selectedFile?.id === "summary") {
       const completedCount = files.filter(file => file.status === "completed" && file.file_result !== "error" && file.id !== "summary").length;
       const totalCount = files.filter(file => file.id !== "summary").length;
       const errorCount = selectedFile.errorCount || 0;

tests/e2e-test/pages/HomePage.py

@@ -19,6 +19,7 @@ class HomePage(BasePage):
     FILE_PROCESSED_MSG = "//span[normalize-space()='3 files processed successfully']"
 
     def __init__(self, page):
+        super().__init__(page)
         self.page = page
 
     def validate_home_page(self):

tests/e2e-test/pages/loginPage.py

@@ -11,6 +11,7 @@ class LoginPage(BasePage):
     PERMISSION_ACCEPT_BUTTON = "//input[@type='submit']"
 
     def __init__(self, page):
+        super().__init__()
         self.page = page
 
     def authenticate(self, username, password):