chore: restructure infra naming conventions and enhance deployment scripts#104
Closed
Harmanpreet-Microsoft wants to merge 4 commits intodevfrom
Closed
chore: restructure infra naming conventions and enhance deployment scripts#104Harmanpreet-Microsoft wants to merge 4 commits intodevfrom
Harmanpreet-Microsoft wants to merge 4 commits intodevfrom
Conversation
added 2 commits
May 20, 2025 11:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several changes focused on standardizing resource naming conventions, improving infrastructure deployment scripts, and enhancing configuration management. Key updates include the addition of a
.dockerignorefile, restructuring of abbreviations ininfra/abbreviations.json, and refactoring of multiple Bicep templates to use the new abbreviations and naming conventions.Configuration and File Management:
.dockerignorefile to exclude unnecessary files and directories from Docker builds, including temporary files, build artifacts, and IDE-specific files.Abbreviation Standardization:
infra/abbreviations.jsonto group abbreviations by resource categories (e.g., AI, analytics, compute, etc.) for improved organization and maintainability. This change introduces new abbreviations for various Azure resources.Bicep Template Refactoring:
infra/deploy_ai_foundry.bicepto dynamically load abbreviations frominfra/abbreviations.jsonand apply them to resource names, ensuring consistency across deployments. This includes changes to variables likestorageName,aiServicesName, andaiHubName. [1] [2] [3]infra/main.bicepby replacing hardcoded prefixes with dynamically generated ones using abbreviations and unique strings, and cleaned up resource naming logic. [1] [2]KeyVault Enhancements:
infra/deploy_keyvault.bicepto enable soft delete and purge protection for Key Vault resources, enhancing security and compliance.These changes collectively improve the maintainability, scalability, and security of the infrastructure codebase.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information