fix: quota validation error fixed#131
Closed
Priyanka-Microsoft wants to merge 16 commits intodevfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces significant enhancements to the quota validation scripts (
validate_model_quota.ps1andvalidate_model_quota.sh) for better usability, error handling, and user guidance. Key changes include improved messaging, input validation, fallback region handling, and a more robust flow for manual user input.Improvements to user messaging and feedback:
validate_model_quota.ps1andvalidate_model_quota.shto provide clearer context, such as displaying available and required quotas ($PrimaryResult.Available,$Capacity) and recommended regions when capacity is below the threshold. [1] [2]Enhanced fallback region handling:
check_fallback_regionsfunction invalidate_model_quota.shto streamline the process of identifying and suggesting fallback regions with sufficient quota. This function also displays a table of fallback regions and their quota details. [1] [2]Improved input validation and user guidance:
RECOMMENDED_TOKENS=200) in both scripts, warning users about potential performance issues if the entered capacity is too low, and prompting for confirmation to proceed. [1] [2]validate_model_quota.shto ensure all required parameters are provided and valid before proceeding.Refactoring and code organization:
validate_model_quota.shby introducing helper functions likeshow_tableandmanual_region_inputfor better modularity and readability. [1] [2]Additional minor updates:
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information