perf: Implement retry logic to improve resiliency#147
Merged
Roopan-Microsoft merged 6 commits intodevfrom Jul 16, 2025
Merged
Conversation
added 4 commits
June 26, 2025 12:54
marktayl1
reviewed
Jul 8, 2025
Contributor
marktayl1
left a comment
There was a problem hiding this comment.
This is great! If we have not, we need to put this through a very thorough test pass. There are a lot of core changes here so it is important to fully test, not just smoke testing. If that has been done, I am good if you pull the comments and merge.
Roopan-Microsoft
approved these changes
Jul 16, 2025
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Ritesh-Microsoft
pushed a commit
that referenced
this pull request
Oct 10, 2025
perf: Implement retry logic to improve resiliency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces significant updates to the
CommsManagerclass and its integration into theconvert_script.pyworkflow, focusing on enhanced retry logic, error handling, and communication robustness. Additionally, minor cleanup changes were made to remove unused imports. Below is a breakdown of the most important changes:Enhancements to Communication and Retry Logic
CommsManager: Added retry logic with configurable parameters (max_retries,initial_delay,backoff_factor) to handle rate limits and transient errors in agent communication. The newasync_invokemethod ensures robust retries and error handling, including parsing wait times from error messages. (src/backend/sql_agents/helpers/comms_manager.py, src/backend/sql_agents/helpers/comms_manager.pyR156-R260)CommsManagerRetry Logic inconvert_script.py: Replaced directAgentGroupChatusage withCommsManager, leveraging the new retry mechanism for agent communication. This includes updating calls toadd_chat_messageandinvokemethods. (src/backend/sql_agents/convert_script.py, [1] [2] [3]Improved Error Handling
src/backend/sql_agents/convert_script.py, src/backend/sql_agents/convert_script.pyR207-R242)src/backend/sql_agents/convert_script.py, src/backend/sql_agents/convert_script.pyR251-R276)Code Cleanup
asyncioimports inconvert_script.pyandprocess_batch.py. (src/backend/sql_agents/convert_script.py, [1];src/backend/sql_agents/process_batch.py, [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information