feat: Meaningful error notification if file upload fails due to uploading invalid file#196
Merged
Roopan-Microsoft merged 9 commits intodevfrom Aug 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the file upload component by adding stricter validation for uploaded files and providing clear user feedback when files are rejected. The changes ensure only .sql files are accepted and users receive detailed error messages for invalid uploads.
- Added manual file extension validation to complement existing MIME type checks
- Implemented comprehensive error handling with user-friendly error messages for file rejections
- Enhanced UI with error message display using MessageBar component
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Roopan-Microsoft
approved these changes
Aug 28, 2025
Ritesh-Microsoft
pushed a commit
that referenced
this pull request
Oct 10, 2025
feat: Meaningful error notification if file upload fails due to uploading invalid file
|
🎉 This PR is included in version 1.5.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
https://dev.azure.com/CSACTOSOL/CSA%20Solutioning/_workitems/edit/22335/
This pull request improves the file upload experience in the
FileUploadZonecomponent by adding stricter validation for uploaded files and providing clear feedback to users when files are rejected. The changes ensure that only.sqlfiles are accepted and that users are informed of any issues with their uploads, such as invalid file type or exceeding the size limit.File validation and error handling improvements:
.sqlextension are accepted, regardless of MIME type, and constructed detailed error messages for invalid files and files exceeding the size limit. These errors are displayed to the user.fileRejectionErrorsstate to track and display file rejection reasons, and ensured errors are cleared when valid files are uploaded or the upload is canceled. [1] [2]MessageBarcomponent, making it clear to users why their files were not accepted.Configuration and documentation updates:
.sqlfiles are accepted by extension, and updated theacceptproperty to reinforce this restriction. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information