fix: consistent picker response#198
Merged
Roopan-Microsoft merged 1 commit intodevfrom Aug 25, 2025
Merged
Conversation
Shreyas-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
marktayl1
as code owners
Roopan-Microsoft
approved these changes
Aug 25, 2025
Ritesh-Microsoft
pushed a commit
that referenced
this pull request
Oct 10, 2025
fix: consistent picker response
|
🎉 This PR is included in version 1.5.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request improves the robustness of the agent response handling in the
convert_scriptfunction by adding error handling for invalid JSON responses from the Picker and Semantic Verifier agents. If an agent returns an invalid response, the system now logs the error and falls back to a default response, preventing crashes and ensuring the workflow continues smoothly.Agent response error handling improvements:
PickerResponse.model_validate_jsonto catch and log errors from invalid Picker agent responses, and to provide a defaultPickerResponsefallback.SemanticVerifierResponse.model_validate_jsonto catch and log errors from invalid Semantic Verifier agent responses, and to provide a defaultSemanticVerifierResponsefallback.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information