ci: ensure Service Principal has Contributor role on resource group and fix infra formatting#212
Merged
Roopan-Microsoft merged 7 commits intomicrosoft:devfrom Sep 16, 2025
Merged
Conversation
Updated createdDate parameter to use utcNow function.
Add role assignment step for Service Principal in deployment workflow.
Removed createdDate parameter from deployment.
Update deploy.yml
Harmanpreet-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
marktayl1
as code owners
Roopan-Microsoft
approved these changes
Sep 16, 2025
Ritesh-Microsoft
pushed a commit
that referenced
this pull request
Oct 10, 2025
ci: ensure Service Principal has Contributor role on resource group and fix infra formatting
|
🎉 This PR is included in version 1.5.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces a key update to the deployment workflow by ensuring the Service Principal is explicitly granted the Contributor role on the target resource group. This change helps prevent permission issues during deployment. Additionally, there is a minor formatting adjustment in the infrastructure code.
Deployment workflow improvement:
.github/workflows/deploy.yml) to assign the Contributor role to the Service Principal for the resource group, ensuring proper permissions for deployment tasks.Infrastructure code formatting:
infra/main.bicepfile for resource group tags.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information