Skip to content

feat: merging the changes from dev to main#228

Merged
Roopan-Microsoft merged 42 commits intomainfrom
dev
Oct 1, 2025
Merged

feat: merging the changes from dev to main#228
Roopan-Microsoft merged 42 commits intomainfrom
dev

Conversation

@Abdul-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

  • This pull request updates the deployment workflow and infrastructure templates to improve deployment flexibility and security, and to simplify configuration. The most significant changes include enabling dynamic Azure region selection, assigning required Azure roles to the service principal, and removing the WAF-aligned architecture toggle from the infrastructure template.

Deployment Workflow Improvements

  • Added a step to set the deployment region dynamically using the VALID_REGION environment variable, allowing deployments to be targeted to different Azure regions.
  • Updated the Bicep deployment command to use the dynamically set AZURE_LOCATION instead of a hardcoded region.
  • Added steps to assign the "Contributor" and "Log Analytics Contributor" roles to the service principal at the resource group level, ensuring proper permissions for deployment and monitoring.

Infrastructure Template Simplification

  • Removed the useWafAlignedArchitecture parameter and all its dependencies, simplifying the template and defaulting related features (enableMonitoring, enableScaling, enablePrivateNetworking) to false. [1] [2] [3]
  • Updated resource tagging to include a new Type tag that reflects whether private networking is enabled (WAF or Non-WAF).

Metadata and Tagging Enhancements

  • Improved the logic for the createdBy tag to better handle different deployer identity scenarios, and updated its description for clarity.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 0e3afe9 into main Oct 1, 2025
13 of 15 checks passed
Ritesh-Microsoft pushed a commit that referenced this pull request Oct 10, 2025
feat: merging the changes from dev to main
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants