Skip to content

fix: Dev to main#233

Merged
Roopan-Microsoft merged 7 commits intomainfrom
dev
Oct 13, 2025
Merged

fix: Dev to main#233
Roopan-Microsoft merged 7 commits intomainfrom
dev

Conversation

@NirajC-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

This pull request introduces documentation for post-deployment steps, updates Azure deployment workflow permissions, and improves error handling in quota checks. The main changes are grouped below:

Documentation:

  • Added a new docs/AVMPostDeploymentGuide.md file to provide step-by-step instructions for post-deployment actions after using the AVM template, including accessing the application and enabling authentication.

Azure Deployment Workflow:

  • Updated .github/workflows/deploy.yml to explicitly set the Azure subscription after logging in, ensuring subsequent commands are executed in the correct subscription context.
  • Changed the Log Analytics role assignment from Log Analytics Contributor to Log Analytics Reader for the service principal, reducing permissions to the minimum required for workspace access.

Quota Check Script:

  • Improved error handling in scripts/checkquota.sh by marking quota as insufficient when no model info is found, ensuring more accurate reporting.
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 2ceb956 into main Oct 13, 2025
22 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants