fix: gp bug and Managed identity changes#375
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to improve “golden path” reliability and environment-aware Azure authentication, while enhancing the modernization UI’s progress/error handling and tightening Docker build context for the frontend.
Changes:
- Backend: make Azure credential selection depend on
APP_ENV(dev vs non-dev) and adjust script-conversion loop completion detection. - Frontend: adjust modernization page completion/navigation logic and add a progress-based loading timeout behavior.
- Build: reduce frontend Docker build context via
.dockerignore.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/frontend/src/pages/modernizationPage.tsx |
Updates modernization progress/navigation/error handling and file-loading logic. |
src/frontend/.dockerignore |
Excludes bulky/unneeded dirs from frontend Docker build context. |
src/backend/sql_agents/convert_script.py |
Refactors conversion loop termination logic using a boolean completion flag. |
src/backend/common/config/config.py |
Makes Azure credential selection environment-aware (dev vs prod/managed identity). |
src/backend/.env.sample |
Sets sample logging levels to DEBUG for easier development debugging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Purpose
This pull request introduces several improvements and fixes across both the backend and frontend. The main changes include enhanced Azure credential handling for different environments, improved logging configuration for debugging, a fix to the script conversion loop logic, and frontend updates for better progress tracking and error handling.
Backend Improvements
ClientSecretCredentialorAioDefaultAzureCredential, while in production it defaults toAioManagedIdentityCredential, ensuring the correct authentication method is used based onAPP_ENV. [1] [2]DEBUGby default in.env.sampleto facilitate easier debugging during development.convert_script.pynow uses a boolean flag (is_complete) for clearer and more robust completion detection. [1] [2]Frontend Enhancements
progressPercentagestate and improved the loading timeout logic to show an error only if progress is less than 5% after 30 seconds, providing a better user experience during long operations. [1] [2].dockerignoreto excludenode_modules,dist, and.gitfrom frontend Docker builds, reducing image size and build time.Other minor changes include importing additional React hooks and minor refactoring of file loading logic in the modernization page. [1] [2]
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information