fix: Explicit returns mixed with implicit (fall through) returns#376
Merged
Roopan-Microsoft merged 1 commit intodevfrom Mar 24, 2026
Merged
fix: Explicit returns mixed with implicit (fall through) returns#376Roopan-Microsoft merged 1 commit intodevfrom
Roopan-Microsoft merged 1 commit intodevfrom
Conversation
Priyanka-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
marktayl1,
nchandhi and
toherman-msft
as code owners
Priyanka-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Priyanka-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to clarify the behavior of the SQL agents’ SelectionStrategy.select_agent by explicitly returning None when no selection case matches.
Changes:
- Added an explicit
return Noneat the end of theselect_agentmatch block incomms_manager.py.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Priyanka-Microsoft
changed the title
Roopan-Microsoft
approved these changes
Mar 24, 2026
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
...
This pull request makes a minor update to the
select_agentfunction incomms_manager.pyto ensure thatNoneis explicitly returned when no matching case is found. This improves code clarity and makes the function's behavior more predictable.Explicitly return
Noneinselect_agentwhen no matching case is found incomms_manager.py.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information