fix: fix copilot comments - enhance batch handling in CosmosDBClient and add tests for conflict scenarios#399
Merged
Roopan-Microsoft merged 1 commit intodevfrom Apr 8, 2026
Merged
Conversation
Roopan-Microsoft
approved these changes
Apr 8, 2026
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request improves error handling and test coverage for batch creation and file upload in the CosmosDB integration, and fixes type consistency for file and batch IDs. The main changes include refactoring permission errors, adding comprehensive tests for batch creation edge cases, and ensuring correct UUID usage.
Error handling improvements:
CosmosResourceNotFoundErrortoPermissionErrorincreate_batch, making permission issues explicit and more accurate.Test coverage enhancements:
PermissionErrorfor cross-user access.RuntimeErrorwhen read retries are exhausted.CosmosResourceNotFoundError.partition_keyis used in batch and file queries. [1] [2]Type consistency and bug fixes:
upload_file_to_batchpassesUUIDobjects forbatch_idandfile_idtoadd_file, fixing a potential type mismatch.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation