refactor: centralize Azure resource naming with abbreviations.json and update Bicep templates#95
Closed
Harmanpreet-Microsoft wants to merge 154 commits intodevfrom
Closed
refactor: centralize Azure resource naming with abbreviations.json and update Bicep templates#95Harmanpreet-Microsoft wants to merge 154 commits intodevfrom
Harmanpreet-Microsoft wants to merge 154 commits intodevfrom
Conversation
Vertically align landing page
…-registry ci: build docker image and push to container registry
ci: added github files
fix: skip docker login on push
style: Pylint fixes
feat: added one click deployment github action pipeline
fix: Bug-15313 "selected state" in the left panel.
feat: backend unit test cases: part-I
fix: bring consistency for "cancel" behavior from home screen
Hotfix to main branch
fix: updates to a GitHub Actions workflow and infrastructure configuration files
feat: updated one click deployment github action parameters
docs: Add customization docs
fix: removed apiProperties.statisticsEnabled property from code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces a major reorganization and standardization of resource naming conventions across the infrastructure codebase. The changes include adding a centralized
abbreviations.jsonfile to define consistent abbreviations for resource types and updating the Bicep templates to use these abbreviations dynamically. Additionally, some parameters have been refactored for improved flexibility and maintainability.Centralized Abbreviation Management:
abbreviations.jsonfile to define standardized abbreviations for various Azure resource types, organized by categories such asai,analytics,compute,databases,networking, and more. This replaces hardcoded naming patterns with a centralized approach.Updates to Bicep Templates:
infra/main.bicepto load theabbreviations.jsonfile and use its values for naming resources dynamically, including storage accounts, AI services, managed identities, and container apps. [1] [2] [3] [4] [5] [6] [7] [8]infra/deploy_ai_foundry.bicepto use abbreviations for AI-related resources like AI services, AI hubs, and key vaults, replacing hardcoded names with dynamically generated ones.infra/deploy_keyvault.bicepandinfra/deploy_managed_identity.bicepto acceptkeyvaultNameandmiNameas parameters, removing reliance on concatenated strings for naming. [1] [2]These changes improve maintainability, readability, and consistency across the infrastructure codebase.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information