Skip to content

refactor: centralize Azure resource naming with abbreviations.json and update Bicep templates#95

Closed
Harmanpreet-Microsoft wants to merge 154 commits intodevfrom
psl-refactorbicep
Closed

refactor: centralize Azure resource naming with abbreviations.json and update Bicep templates#95
Harmanpreet-Microsoft wants to merge 154 commits intodevfrom
psl-refactorbicep

Conversation

@Harmanpreet-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

This pull request introduces a major reorganization and standardization of resource naming conventions across the infrastructure codebase. The changes include adding a centralized abbreviations.json file to define consistent abbreviations for resource types and updating the Bicep templates to use these abbreviations dynamically. Additionally, some parameters have been refactored for improved flexibility and maintainability.

Centralized Abbreviation Management:

  • Created a new abbreviations.json file to define standardized abbreviations for various Azure resource types, organized by categories such as ai, analytics, compute, databases, networking, and more. This replaces hardcoded naming patterns with a centralized approach.

Updates to Bicep Templates:

  • Updated infra/main.bicep to load the abbreviations.json file and use its values for naming resources dynamically, including storage accounts, AI services, managed identities, and container apps. [1] [2] [3] [4] [5] [6] [7] [8]
  • Modified infra/deploy_ai_foundry.bicep to use abbreviations for AI-related resources like AI services, AI hubs, and key vaults, replacing hardcoded names with dynamically generated ones.
  • Refactored infra/deploy_keyvault.bicep and infra/deploy_managed_identity.bicep to accept keyvaultName and miName as parameters, removing reliance on concatenated strings for naming. [1] [2]

These changes improve maintainability, readability, and consistency across the infrastructure codebase.

  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

gpickett and others added 30 commits March 31, 2025 13:58
Vertically align landing page
…-registry

ci: build docker image and push to container registry
feat: added one click deployment github action pipeline
fix: Bug-15313 "selected state" in the left panel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants