Fix linting errors: revert _app to app where used, remove unused imports, fix indentation

Author: Prachig-Microsoft

src/tests/ContentProcessorAPI/helpers/test_azure_credential_utils.py

@@ -6,7 +6,6 @@
 import os
 import sys
 from unittest.mock import MagicMock, patch
-import pytest
 
 sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), "..", "..", "..", "ContentProcessorAPI")))
 

src/tests/ContentProcessorAPI/libs/test_app_configuration_helper.py

@@ -6,7 +6,6 @@
 import os
 import sys
 from unittest.mock import MagicMock, patch
-import pytest
 
 sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), "..", "..", "..", "ContentProcessorAPI")))
 

src/tests/ContentProcessorAPI/libs/test_cosmos_db_helper.py

@@ -86,7 +86,7 @@ def test_find_document(mock_certifi, mock_mongo_client):
     mock_cursor.__iter__.return_value = iter(mock_items)
 
     query = {"key": "value"}
-    _result = helper.find_document(
+    helper.find_document(
         query=query,
         sort_fields=[("field", 1)],
         skip=10,
@@ -167,7 +167,7 @@ def test_delete_document(mock_certifi, mock_mongo_client):
     mock_result = MagicMock()
     mock_container.delete_one.return_value = mock_result
 
-    _result = helper.delete_document("test_id")
+    helper.delete_document(\"test_id\")
     mock_container.delete_one.assert_called_once_with({"Id": "test_id"})
 
 

src/tests/ContentProcessorWorkflow/libs/test_application_base_extended.py

@@ -38,7 +38,7 @@ def test_initialization_with_explicit_env_file(self, tmp_path):
             mock_cred_instance = Mock()
             mock_cred.return_value = mock_cred_instance
 
-            _app = ConcreteApplication(env_file_path=str(env_file))
+            app = ConcreteApplication(env_file_path=str(env_file))
 
             assert app.application_context is not None
             assert isinstance(app.application_context, AppContext)
@@ -60,7 +60,7 @@ def test_initialization_auto_discover_env_file(self, tmp_path, monkeypatch):
             mock_getfile.return_value = str(test_file)
             mock_cred.return_value = Mock()
 
-            _app = ConcreteApplication()
+            app = ConcreteApplication()
 
             assert app.application_context is not None
             assert app.initialized is True
@@ -81,7 +81,7 @@ def test_initialization_with_app_config_endpoint(self, tmp_path, monkeypatch):
             mock_app_config_instance = Mock()
             mock_app_config.return_value = mock_app_config_instance
 
-            _app = ConcreteApplication(env_file_path=str(env_file))
+            app = ConcreteApplication(env_file_path=str(env_file))
 
             mock_app_config.assert_called_once()
             mock_app_config_instance.read_and_set_environmental_variables.assert_called_once()
@@ -101,7 +101,7 @@ def test_initialization_with_logging_enabled(self, tmp_path, monkeypatch):
 
             mock_cred.return_value = Mock()
 
-            _app = ConcreteApplication(env_file_path=str(env_file))
+            app = ConcreteApplication(env_file_path=str(env_file))
 
             # Verify logging was configured
             mock_logging.assert_called_once()
@@ -122,7 +122,7 @@ def test_initialization_without_logging(self, tmp_path, monkeypatch):
 
             mock_cred.return_value = Mock()
 
-            _app = ConcreteApplication(env_file_path=str(env_file))
+            app = ConcreteApplication(env_file_path=str(env_file))
 
             # Verify logging was NOT configured
             mock_logging.assert_not_called()
@@ -140,7 +140,7 @@ def test_initialization_sets_llm_settings(self, tmp_path):
             mock_llm_instance = Mock()
             mock_llm_settings.return_value = mock_llm_instance
 
-            _app = ConcreteApplication(env_file_path=str(env_file))
+            app = ConcreteApplication(env_file_path=str(env_file))
 
             assert app.application_context.llm_settings == mock_llm_instance
             mock_llm_settings.assert_called_once_with(
@@ -158,7 +158,7 @@ def test_load_env_with_explicit_path(self, tmp_path):
              patch('libs.base.application_base.AgentFrameworkSettings'), \
              patch('libs.base.application_base.load_dotenv') as mock_load_dotenv:
 
-            _app = ConcreteApplication(env_file_path=str(env_file))
+            app = ConcreteApplication(env_file_path=str(env_file))
 
             # Verify load_dotenv was called at least once
             assert mock_load_dotenv.call_count >= 1
@@ -177,7 +177,7 @@ def test_get_derived_class_location(self, tmp_path):
             test_env = tmp_path / ".env"
             test_env.write_text("APP_LOGGING_ENABLE=false\n")
 
-            _app = ConcreteApplication(env_file_path=str(test_env))
+            app = ConcreteApplication(env_file_path=str(test_env))
 
             location = app._get_derived_class_location()
 
@@ -196,7 +196,7 @@ def test_application_context_credential_set(self, tmp_path):
             mock_cred_instance = Mock()
             mock_cred.return_value = mock_cred_instance
 
-            _app = ConcreteApplication(env_file_path=str(env_file))
+            app = ConcreteApplication(env_file_path=str(env_file))
 
             assert app.application_context.credential == mock_cred_instance
 
@@ -211,7 +211,7 @@ def test_application_context_configuration_set(self, tmp_path, monkeypatch):
              patch('libs.base.application_base.AppConfigurationHelper'), \
              patch('libs.base.application_base.AgentFrameworkSettings'):
 
-            _app = ConcreteApplication(env_file_path=str(env_file))
+            app = ConcreteApplication(env_file_path=str(env_file))
 
             assert app.application_context.configuration is not None
 
@@ -224,7 +224,7 @@ def test_run_method_called(self, tmp_path):
              patch('libs.base.application_base.AppConfigurationHelper'), \
              patch('libs.base.application_base.AgentFrameworkSettings'):
 
-            _app = ConcreteApplication(env_file_path=str(env_file))
+            app = ConcreteApplication(env_file_path=str(env_file))
 
             assert app.running is False
             app.run()
@@ -241,7 +241,7 @@ def test_initialize_method_called_during_init(self, tmp_path):
 
             # initialized flag is set in ConcreteApplication.__init__ which calls super().__init__
             # But the initialize() method sets initialized=True
-            _app = ConcreteApplication(env_file_path=str(env_file))
+            app = ConcreteApplication(env_file_path=str(env_file))
 
             # The initialize() method should have been called in ConcreteApplication.__init__
             assert app.initialized is True
@@ -257,7 +257,7 @@ def test_empty_app_config_endpoint_skipped(self, tmp_path, monkeypatch):
              patch('libs.base.application_base.AppConfigurationHelper') as mock_app_config, \
              patch('libs.base.application_base.AgentFrameworkSettings'):
 
-            _app = ConcreteApplication(env_file_path=str(env_file))
+            app = ConcreteApplication(env_file_path=str(env_file))
 
             # AppConfigurationHelper should not be called with empty endpoint
             mock_app_config.assert_not_called()
@@ -274,7 +274,7 @@ def test_none_app_config_endpoint_skipped(self, tmp_path, monkeypatch):
              patch('libs.base.application_base.AppConfigurationHelper') as mock_app_config, \
              patch('libs.base.application_base.AgentFrameworkSettings'):
 
-            _app = ConcreteApplication(env_file_path=str(env_file))
+            app = ConcreteApplication(env_file_path=str(env_file))
 
             # AppConfigurationHelper should not be called
             mock_app_config.assert_not_called()

src/tests/ContentProcessorWorkflow/libs/test_final_80_percent_push.py

@@ -12,14 +12,14 @@ def test_service_scope_get_service_not_registered(self):
 
         context = AppContext()
 
-
         class UnregisteredService:
             pass
 
         # Attempt to get unregistered service should raise or return None
         with pytest.raises(Exception):  # KeyError or custom exception
             if hasattr(context, 'create_scope'):
                 import asyncio
+
                 async def test():
                     async with await context.create_scope() as scope:
                         scope.get_service(UnregisteredService)
@@ -221,7 +221,7 @@ def test_get_azure_credential_with_all_env_vars(self):
             'AZURE_TENANT_ID': 'test-tenant-id',
             'AZURE_CLIENT_SECRET': 'test-secret'
         }), \
-             patch('utils.credential_util.DefaultAzureCredential') as mock_cred:
+            patch('utils.credential_util.DefaultAzureCredential') as mock_cred:
 
             mock_cred.return_value = Mock()
 

src/tests/ContentProcessorWorkflow/libs/test_push_to_80_percent.py

@@ -26,7 +26,7 @@ def run(self):
             mock_env_config.return_value.app_config_endpoint = ""
 
             # Test with explicit path
-            _app = TestApp(env_file_path="/custom/path/.env")
+            app = TestApp(env_file_path="/custom/path/.env")
 
             # Should have loaded from explicit path
             mock_load_dotenv.assert_called_with(dotenv_path="/custom/path/.env")
@@ -43,7 +43,7 @@ def run(self):
                 pass
 
         with patch('libs.base.application_base.load_dotenv'), \
-             patch('libs.base.application_base.DefaultAzureCredential'), \\
+             patch('libs.base.application_base.DefaultAzureCredential'), \
              patch('libs.base.application_base.Configuration') as mock_config, \
              patch('libs.base.application_base.AgentFrameworkSettings'), \
              patch('libs.base.application_base._envConfiguration') as mock_env_config, \
@@ -53,7 +53,7 @@ def run(self):
             mock_env_config.return_value.app_config_endpoint = "https://myconfig.azconfig.io"
             mock_config.return_value.app_logging_enable = False
 
-            _app = TestApp()
+            app = TestApp()
 
             # Should have created AppConfigurationHelper
             assert mock_app_config.called
@@ -85,7 +85,7 @@ def run(self):
             config_instance.app_logging_level = "DEBUG"
             mock_config.return_value = config_instance
 
-            _app = TestApp()
+            app = TestApp()
 
             # Should have configured logging
             mock_logging.assert_called_once()

src/tests/ContentProcessorWorkflow/libs/test_ultra_focused_80.py

@@ -58,7 +58,7 @@ def test_safe_log_with_complex_formatting(self):
 
         logger = Mock()
         safe_log(logger, "info", "User {user} performed {action} on {resource}",
-                user="alice", action="update", resource="document")
+                 user="alice", action="update", resource="document")
 
         assert logger.info.called
         call_str = str(logger.info.call_args)
@@ -102,7 +102,7 @@ def run(self):
             mock_config.return_value.app_logging_enable = False
 
             # Create app with no explicit env path
-            _app = TestApp()
+            app = TestApp()
 
             # Should have called load_dotenv
             assert mock_load.called
@@ -119,7 +119,7 @@ def test_validate_authentication_with_kubernetes(self):
             'KUBERNETES_SERVICE_HOST': 'kubernetes.default.svc',
             'IDENTITY_ENDPOINT': 'http://169.254.169.254/metadata/identity'
         }), \
-             patch('utils.credential_util.get_azure_credential') as mock_cred:
+            patch('utils.credential_util.get_azure_credential') as mock_cred:
 
             mock_cred.return_value = Mock()