fix: pipeline login server tag not found#139
Merged
Roopan-Microsoft merged 2 commits intomainfrom May 22, 2025
Merged
Conversation
Priyanka-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Priyanka-Microsoft
changed the title
Roopan-Microsoft
approved these changes
May 22, 2025
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the
.github/workflows/build-docker-image.ymlfile to improve how Docker image tags are generated and to standardize the use of the external registry. The changes ensure better flexibility and consistency in handling the registry URL by introducing a new step to retrieve the registry dynamically.Workflow improvements:
GITHUB_OUTPUTcontext for subsequent steps. ([.github/workflows/build-docker-image.ymlL34-R42](https://github.com/microsoft/content-processing-solution-accelerator/pull/139/files#diff-5b40193e09025fd041de92d38c976d0b469e3ee85bef45a71d05d8b5078b1ee8L34-R42))steps.registry.outputs.ext_registry) instead of the staticenv.ACR_LOGIN_SERVERvariable for theContentProcessor,ContentProcessorAPI, andContentProcessorWebimages. ([[1]](https://github.com/microsoft/content-processing-solution-accelerator/pull/139/files#diff-5b40193e09025fd041de92d38c976d0b469e3ee85bef45a71d05d8b5078b1ee8L67-R73),[[2]](https://github.com/microsoft/content-processing-solution-accelerator/pull/139/files#diff-5b40193e09025fd041de92d38c976d0b469e3ee85bef45a71d05d8b5078b1ee8L77-R83),[[3]](https://github.com/microsoft/content-processing-solution-accelerator/pull/139/files#diff-5b40193e09025fd041de92d38c976d0b469e3ee85bef45a71d05d8b5078b1ee8L87-R93))Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information