fix: merging dev changes to main#179
Merged
Roopan-Microsoft merged 19 commits intomainfrom Jun 9, 2025
Merged
Conversation
fix: parameterized for model version
…t automation workflow
…e groups and container apps
feat: Standardize Bicep Parameters for Content Processing
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges development changes into main and introduces new end-to-end tests, updated configuration files, and enhanced deployment documentation for the Content Processing Accelerator.
- Adds new e2e tests and page objects for content processing
- Introduces updated configuration and dependency files for testing and deployment
- Improves documentation and GitHub workflow setup for automated test execution
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e-test/tests/test_contentProcessing_gp_tc.py | New e2e test case for the content processing golden path |
| tests/e2e-test/tests/conftest.py | Added session-level fixture and report customizations |
| tests/e2e-test/requirements.txt | Added required dependencies for e2e testing |
| tests/e2e-test/readme.MD | Provided documentation for running e2e tests |
| tests/e2e-test/pytest.ini | Configured logging and warning suppression |
| tests/e2e-test/pages/loginPage.py | Created a new login page abstraction for e2e tests |
| tests/e2e-test/pages/HomePage.py | Implemented page object with methods for validating processing steps |
| tests/e2e-test/config/constants.py | Defined and cleaned up URL configuration |
| tests/e2e-test/base/base.py | Supplied basic page functionality for reuse in tests |
| tests/e2e-test/.gitignore | Updated ignore patterns for test artifacts |
| infra/main.json | Updated template hash and modified allowed parameters |
| infra/main.bicepparam | Introduced additional parameters for deployment settings |
| infra/main.bicep | Removed extra annotation validations from GPT model parameters |
| docs/DeploymentGuide.md | Updated deployment guide with configurable settings |
| docs/CustomizingAzdParameters.md | Enhanced parameter documentation with a detailed configuration table |
| .github/workflows/test-automation.yml | Added and configured a GitHub workflow for test automation |
AjitPadhi-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
feat: added image tag related changes.
Roopan-Microsoft
approved these changes
Jun 9, 2025
|
🎉 This PR is included in version 1.5.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
imageTagparameter for container builds, modifications to the test automation workflow, and updates to documentation for better clarity and usability.Deployment Enhancements:
imageTagparameter to support custom image tags for container builds ininfra/container_app/deploy_container_app_api_web.bicepandinfra/main.bicep. This improves flexibility in specifying image versions during deployment.infra/scripts/docker-build.ps1to include theAZURE_ENV_IMAGETAGargument, enabling dynamic image tagging during Docker build and push operations.Test Automation Workflow:
.github/workflows/test-automation.yml) for running end-to-end tests. Includes retry logic for failed tests, container app management, and notification handling for test results.Documentation Updates:
docs/CustomizingAzdParameters.mdwith a detailed table of parameters, including descriptions and example values, to improve clarity and ease of customization.docs/DeploymentGuide.mdto reflect new settings such asImage TagandGPT Model Version, and revised formatting for better readability.Configuration Improvements:
AZURE_ENV_IMAGETAGenvironment variable inazure.yamlto pass custom image tags during preprovisioning steps.infra/main.bicepparamto include theimageTagparameter and other new parameters for deployment customization.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information