fix: add principalType as 'ServicePrincipal' for role assignments#224
Merged
Prajwal-Microsoft merged 2 commits intomainfrom Jul 22, 2025
Merged
fix: add principalType as 'ServicePrincipal' for role assignments#224Prajwal-Microsoft merged 2 commits intomainfrom
Prajwal-Microsoft merged 2 commits intomainfrom
Conversation
Prajwal-Microsoft
approved these changes
Jul 22, 2025
|
🎉 This PR is included in version 1.8.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
infra/main.bicepandinfra/main.json) to improve security and functionality. The key changes include the addition ofprincipalType: 'ServicePrincipal'across multiple role assignments and the replacement of outdatedreference()calls withlistOutputsWithSecureValues()for secure resource access.Updates to Role Assignments:
principalType: 'ServicePrincipal'to role assignments ininfra/main.bicepfor modules such asavmKeyVault,avmStorageAccount,avmAiServices, andavmAppConfig. This ensures the correct principal type is used for service roles. [1] [2] [3] [4]infra/main.jsonfor roles such asKey Vault Administrator,Storage Blob Data Contributor, andApp Configuration Data Reader. [1] [2] [3]Secure Resource Access:
reference()calls withlistOutputsWithSecureValues()for accessing resources like Log Analytics Workspace and Storage Account ininfra/main.json. This improves security by using secure values for outputs. [1] [2] [3]Miscellaneous Improvements:
infra/main.jsonto reflect changes in the deployment templates. [1] [2]infra/main.jsonfor private DNS zones to ensure proper sequencing.These changes enhance the security and maintainability of the infrastructure code while ensuring compatibility with updated Azure resource configurations.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information