Skip to content

chore: Corrected the invalid reference#294

Merged
Prajwal-Microsoft merged 1 commit intomicrosoft:devfrom
Kanchan-Microsoft:main
Oct 21, 2025
Merged

chore: Corrected the invalid reference#294
Prajwal-Microsoft merged 1 commit intomicrosoft:devfrom
Kanchan-Microsoft:main

Conversation

@Kanchan-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

This pull request updates the deployment configuration for the AI Foundry and related resources, refines diagnostic settings handling, and adjusts resource dependencies to improve AVM compliance and robustness. The most important changes are organized below:

AI Foundry Resource Module Update:

  • The AI Foundry module reference in infra/main.bicep was changed from modules/account/main.bicep to modules/account/aifoundry.bicep, ensuring the correct resource definitions are used for AI services.

Diagnostic Settings Handling:

  • Diagnostic settings for resources now use a conditional expression to handle empty logAnalyticsWorkspaceResourceId parameters, resulting in either a null value or a properly formatted array. This makes the deployment more robust and prevents errors when telemetry is not configured.

Resource Dependencies:

  • The order and inclusion of private DNS zone dependencies were updated to ensure correct sequencing and resource availability during deployment, specifically for the contentUnderstanding DNS zone.

Template Hash Updates:

  • Bicep-generated template hashes in infra/main.json were updated to reflect the latest changes in resource definitions and deployment logic. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Prajwal-Microsoft Prajwal-Microsoft merged commit 88da275 into microsoft:dev Oct 21, 2025
3 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.10.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants