Skip to content

fix: Merging the changes from dev to main#300

Merged
Prajwal-Microsoft merged 2 commits intomainfrom
dev
Oct 28, 2025
Merged

fix: Merging the changes from dev to main#300
Prajwal-Microsoft merged 2 commits intomainfrom
dev

Conversation

@Kanchan-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

This pull request updates how tags are applied to the resource group and adjusts the dependencies order in the deployment templates. The main improvements are merging existing resource group tags and user-provided tags, and ensuring the correct dependency order for private DNS zones.

Tag management improvements:

  • Tags assigned to the resource group now merge existing resource group tags, user-provided tags, and predefined tags (like TemplateName, Type, and CreatedBy) in both main.bicep and main.json. This ensures no tags are lost or overwritten during deployment.

Dependency order adjustments:

  • The order of dependencies for private DNS zones in main.json has been updated to ensure correct deployment sequencing, particularly for openAI and cognitiveServices DNS zones.

Other updates:

  • The Bicep-generated template hash in main.json has been updated to reflect these changes.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Kanchan-Microsoft and others added 2 commits October 28, 2025 14:12
fix: Prevent removal of existing RG tags when deploying GSA
@Prajwal-Microsoft Prajwal-Microsoft merged commit 3ea28d8 into main Oct 28, 2025
10 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.10.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants