fix: merge from dev to main #310
Merged
Prajwal-Microsoft merged 19 commits intomainfrom Nov 10, 2025
Merged
Conversation
Added detailed instructions for sample workflow
Updated task descriptions for clarity and corrected typos.
Added a section on running the application and corrected a typo in the environment configuration.
Updated the Sample Workflow documentation to improve clarity and formatting.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Added note about average response time for uploads.
fix: Added a maximum 20-character limit to the environment name.
docs: Added new Sample Questions page and reference file
Thanusree-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces validation constraints for the solutionName parameter and fixes dependency ordering issues in the infrastructure deployment configuration.
- Added length constraints (min: 3, max: 20 characters) to the
solutionNameparameter - Reordered DNS zone dependencies in multiple resource deployment sections
- Added a new Sample Workflow documentation file with usage instructions
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| infra/main.bicep | Added @minLength and @maxLength decorators to solutionName parameter and updated its description |
| infra/main.json | Generated JSON template reflecting the Bicep changes, including parameter constraints and dependency reordering |
| docs/SampleWorkflow.md | New documentation file providing step-by-step workflow guidance for using the application |
| docs/DeploymentGuide.md | Added reference link to the new Sample Workflow documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Roopan-Microsoft
approved these changes
Nov 10, 2025
Roopan-Microsoft
changed the title
Prajwal-Microsoft
approved these changes
Nov 10, 2025
|
🎉 This PR is included in version 1.10.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces improvements to the deployment documentation and infrastructure configuration for the Content Processing Solution Accelerator, as well as adds a user-friendly sample workflow guide. The most significant changes are grouped below:
Documentation Enhancements:
docs/DeploymentGuide.md, including a link to a detailed sample workflow for users to follow.docs/SampleWorkflow.mdfile, guiding users through the main app operations such as API exploration, file upload, review, editing, and deletion, with step-by-step instructions and visuals.Infrastructure Configuration Updates:
solutionNameparameter in both the Bicep template (infra/main.bicep) and the generated ARM template (infra/main.json), ensuring consistent validation and clearer description. [1] [2]infra/main.jsonfor private DNS zones, ensuring proper deployment sequencing and resource referencing. [1] [2] [3]infra/main.jsonto reflect the latest changes in the Bicep template.Does this introduce a breaking change?
Other Information
Added new page and reference link in DeploymentGuide.md.