Skip to content

fix: Update deploy.yml - Replace solution prefix logic, add createdDate tag and enforce cleanup with always()#85

Merged
Prajwal-Microsoft merged 1 commit intomainfrom
PSL-BUG-17086
Apr 17, 2025
Merged

fix: Update deploy.yml - Replace solution prefix logic, add createdDate tag and enforce cleanup with always()#85
Prajwal-Microsoft merged 1 commit intomainfrom
PSL-BUG-17086

Conversation

@Prasanjeet-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

  • Replaced the logic for generating a unique solution prefix with a more consistent environment name using a timestamp and random suffix.
  • Added createdDate tag while creating the resource group for better traceability and auditing.
  • Added if: always() to ensure cleanup steps are executed regardless of prior job success/failure.
  • Helps avoid leftover Azure resources and unnecessary costs due to partial failures.

Does this introduce a breaking change?

  • Yes
  • No

What to Check

Verify that the following are valid:

  • Ensure the new environment name logic produces a valid and unique string.
  • Verify the createdDate tag is correctly added in the resource group creation step.
  • Confirm the cleanup step works as expected even if earlier steps fail, due to if: always().

@Prajwal-Microsoft Prajwal-Microsoft merged commit cfe7180 into main Apr 17, 2025
5 checks passed
@Prasanjeet-Microsoft Prasanjeet-Microsoft deleted the PSL-BUG-17086 branch April 21, 2025 16:00
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants