flowey: include repo names in gh-release-download cache keys#3281
Open
jstarks wants to merge 1 commit intomicrosoft:mainfrom
Open
flowey: include repo names in gh-release-download cache keys#3281jstarks wants to merge 1 commit intomicrosoft:mainfrom
jstarks wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The CI cache key for downloaded GitHub release artifacts was an opaque hash like `gh-release-download-c0fe86102c35d692`, which made it impossible to tell from the cache UI what each entry contained or why it was created. This made debugging cache bloat and eviction issues needlessly difficult. Replace the opaque key with a human-readable one that includes the repo name and tag for each downloaded artifact, followed by the hash for uniqueness. A typical key now looks like `gh-release-download-protobuf-27.1_openvmm-deps-0.1.0-20260401.1_<hash>`, making it immediately clear what versions are cached and which version bump orphaned a stale entry. The key is truncated to stay within the 512-character GitHub Actions limit.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the GitHub Actions cache key for downloaded GitHub release artifacts to be human-readable (repo + tag) while retaining a hash suffix for uniqueness, improving diagnostics of cache bloat/eviction in CI.
Changes:
- Builds a descriptive cache key prefix from repo names and tags for each requested release artifact.
- Keeps a hash suffix for uniqueness and truncates the descriptive portion to stay under Actions cache key limits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI cache key for downloaded GitHub release artifacts was an opaque hash like
gh-release-download-c0fe86102c35d692, which made it impossible to tell from the cache UI what each entry contained or why it was created. This made debugging cache bloat and eviction issues needlessly difficult.Replace the opaque key with a human-readable one that includes the repo name and tag for each downloaded artifact, followed by the hash for uniqueness. A typical key now looks like
gh-release-download-protobuf-27.1_openvmm-deps-0.1.0-20260401.1_<hash>, making it immediately clear what versions are cached and which version bump orphaned a stale entry. The key is truncated to stay within the 512-character GitHub Actions limit.