test: add Mac python.org locator coverage#430
Merged
karthiknadig merged 2 commits intomainfrom Apr 22, 2026
Merged
Conversation
Performance Report (macOS)
Legend
|
Test Coverage Report (Windows)
Coverage increased! Great work! |
Performance Report (Windows) ✅
Legend
|
Test Coverage Report (Linux)
Coverage increased! Great work! |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds more deterministic matching and unit tests for identifying python.org macOS framework-based Python environments, reducing false positives while continuing work for #389.
Changes:
- Refines python.org environment detection to require
/Library/Frameworks/Python.framework/Versions/<version>/bin/<python-exe>-shaped paths. - Introduces helper functions for framework path and executable-name validation.
- Adds focused unit tests for accepted/rejected paths and non-macOS behavior.
Show a summary per file
| File | Description |
|---|---|
| crates/pet-mac-python-org/src/lib.rs | Tightens path matching logic and adds unit tests for python.org framework detection. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 3
Performance Report (Linux) ✅
Legend
|
roblourens
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds focused direct coverage for the Mac python.org locator while continuing the #389 coverage work.
Validation:
Refs #389