Add comprehensive tests for lm/utils.ts chatCommand function#7666
Closed
Copilot wants to merge 1 commit intojoshspicer/new-chat-sessionfrom
Closed
Add comprehensive tests for lm/utils.ts chatCommand function#7666Copilot wants to merge 1 commit intojoshspicer/new-chat-sessionfrom
Copilot wants to merge 1 commit intojoshspicer/new-chat-sessionfrom
Conversation
Copilot
AI
changed the title
[WIP] test
Add comprehensive tests for lm/utils.ts chatCommand function
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing test coverage for the
chatCommand()function insrc/lm/utils.ts. The function determines which chat command to use based on theexperimental.useQuickChatconfiguration setting, but was previously untested.Changes Made
src/test/lm/utils.test.tswith comprehensive test coverageQUICK_CHAT_OPENwhenexperimental.useQuickChatistrueOPEN_CHATwhenexperimental.useQuickChatisfalseOPEN_CHATwhen using the default value (undefined/false)Implementation Details
The tests use proper VS Code workspace configuration mocking to simulate different user settings. Each test case:
vscode.workspace.getConfiguration()to return controlled valueschatCommand()functionbeforeEach/afterEachhooksThe implementation follows existing project patterns and passes all linting, hygiene, and TypeScript compilation checks.
Why This Matters
Having test coverage for this utility function ensures that:
This addresses the gap in test coverage for language model utilities and helps maintain code quality standards across the extension.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
update.code.visualstudio.com/opt/hostedtoolcache/node/20.19.4/x64/bin/node ./out/src/test/runTests.js --help(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.