fix: ensure script casing match for activations#287
Merged
karthiknadig merged 1 commit intomicrosoft:mainfrom Apr 11, 2025
Merged
fix: ensure script casing match for activations#287karthiknadig merged 1 commit intomicrosoft:mainfrom
karthiknadig merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix the casing used in activation scripts for Conda environments by standardizing the way activation commands are constructed. Key changes include:
- Splitting the creation of Conda environment info into two functions: getNamedCondaPythonInfo and getPrefixesCondaPythonInfo.
- Updating command arguments for gitbash shell activation to use the provided environment name.
- Simplifying and updating shell activation handling in the built-in venv utilities and shell detection.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/managers/conda/condaUtils.ts | Refactors environment info creation and updates activation args. |
| src/managers/builtin/venvUtils.ts | Simplifies shell command resolution based on available activation files. |
| src/features/common/shellDetector.ts | Normalizes shell names to lowercase for consistency. |
Comments suppressed due to low confidence (2)
src/features/common/shellDetector.ts:142
- Forcing the shell value to lowercase here may affect downstream consumers expecting the original casing. Please verify that all parts of the system accept lowercase shell names.
if (terminal.state.shell && known.includes(terminal.state.shell.toLowerCase())) {
src/managers/conda/condaUtils.ts:342
- The base environment branch now calls getNamedCondaPythonInfo without logging the discovery of a base environment. If this logging is important for debugging, consider reintroducing a log statement.
if (e.name === 'base') {
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
legomushroom
approved these changes
Apr 11, 2025
NguyenCuong1989
referenced
this pull request
in NguyenCuong1989/vscode-python-environments
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #282