add handling for notebook-cells as inputs to API#293
Merged
eleanorjboyd merged 5 commits intomicrosoft:mainfrom Apr 11, 2025
Merged
add handling for notebook-cells as inputs to API#293eleanorjboyd merged 5 commits intomicrosoft:mainfrom
eleanorjboyd merged 5 commits intomicrosoft:mainfrom
Conversation
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
karthiknadig
requested changes
Apr 11, 2025
karthiknadig
approved these changes
Apr 11, 2025
| export function checkUri(scope?: Uri | Uri[] | string): Uri | Uri[] | string | undefined { | ||
| if (scope instanceof Uri) { | ||
| if (scope.scheme === 'vscode-notebook-cell') { | ||
| return Uri.from({ |
Contributor
There was a problem hiding this comment.
@eleanorjboyd this isn't a valid notebook uri
haven't looked at the code, perhaps this has some meaning in this extension
However of you want to find the notebook Uri, you must iterate through all notebooks and find the notebook that has a cell with the matching Uri .
NguyenCuong1989
referenced
this pull request
in NguyenCuong1989/vscode-python-environments
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #278