Skip to content

log to shell type #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anthonykim1 wants to merge 4 commits into from
Closed

log to shell type #294

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce764c7
add log to generate vsix
anthonykim1 Apr 11, 2025
46ea0b9
listen to change event since windows shell detection is slower
anthonykim1 Apr 11, 2025
6c1cdff
contribute env var to test vsix
anthonykim1 Apr 14, 2025
a260fd1
remove unwanted
anthonykim1 Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/features/common/activation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Terminal } from 'vscode';
import { Terminal, window } from 'vscode';
import { PythonCommandRunConfiguration, PythonEnvironment } from '../../api';
import { identifyTerminalShell } from './shellDetector';
import { traceLog } from '../../common/logging';

export function isActivatableEnvironment(environment: PythonEnvironment): boolean {
return !!environment.execInfo?.activation || !!environment.execInfo?.shellActivation;
Expand All @@ -15,6 +16,11 @@ export function getActivationCommand(
environment: PythonEnvironment,
): PythonCommandRunConfiguration[] | undefined {
const shell = identifyTerminalShell(terminal);
traceLog('getActivationCommand: Shell type from API:', shell);
window.onDidChangeTerminalState((e) => {
// traceLog('getActivationCommand: Terminal state changed:', e);
traceLog('the shell type from API inside the listener:', e.state.shell);
});

let activation: PythonCommandRunConfiguration[] | undefined;
if (environment.execInfo?.shellActivation) {
Expand Down
2 changes: 2 additions & 0 deletions src/features/common/shellDetector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { Terminal } from 'vscode';
import { isWindows } from '../../managers/common/utils';
import { vscodeShell } from '../../common/vscodeEnv.apis';
import { getConfiguration } from '../../common/workspace.apis';
import { traceLog } from '../../common/logging';

/*
When identifying the shell use the following algorithm:
Expand Down Expand Up @@ -150,6 +151,7 @@ function fromShellTypeApi(terminal: Terminal): string {

export function identifyTerminalShell(terminal: Terminal): string {
let shellType = fromShellTypeApi(terminal);
traceLog('IdentifyTerminalShell: Shell type from API:', shellType);

if (shellType === 'unknown') {
shellType = identifyShellFromVSC(terminal);
Expand Down