Remove now unused ChatSessionChangedFile interface" (#308701)#309939
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Apr 14, 2026
Merged
Remove now unused ChatSessionChangedFile interface" (#308701)#309939mjbvz merged 1 commit intomicrosoft:mainfrom
ChatSessionChangedFile interface" (#308701)#309939mjbvz merged 1 commit intomicrosoft:mainfrom
Conversation
Reapplying this now that our d.ts files are in sync
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes the ChatSessionChangedFile2 proposed API type and consolidates callers to use ChatSessionChangedFile for reporting changed files in chat session statistics.
Changes:
- Updates proposed d.ts to remove the
ChatSessionChangedFile2type and narrowchangestoChatSessionChangedFile[] - Removes
ChatSessionChangedFile2from the ext host API surface and types - Updates Copilot chat session providers/worktree service to instantiate and return
ChatSessionChangedFile
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.chatSessionsProvider.d.ts | Drops ChatSessionChangedFile2 and narrows changes to ChatSessionChangedFile[]. |
| src/vs/workbench/api/common/extHostTypes.ts | Removes ChatSessionChangedFile2 class and repurposes ChatSessionChangedFile constructor/signature. |
| src/vs/workbench/api/common/extHost.api.impl.ts | Stops exporting ChatSessionChangedFile2 from the API factory. |
| extensions/copilot/src/extension/chatSessions/vscode-node/copilotCloudSessionsProvider.ts | Switches instantiation from ChatSessionChangedFile2 to ChatSessionChangedFile. |
| extensions/copilot/src/extension/chatSessions/vscode-node/copilotCLIChatSessionsContribution.ts | Updates array types and instantiation to ChatSessionChangedFile. |
| extensions/copilot/src/extension/chatSessions/vscode-node/copilotCLIChatSessions.ts | Updates return type and instantiation to ChatSessionChangedFile. |
| extensions/copilot/src/extension/chatSessions/vscode-node/chatSessionWorktreeServiceImpl.ts | Updates worktree changes return types and constructors to ChatSessionChangedFile. |
| extensions/copilot/src/extension/chatSessions/common/chatSessionWorktreeService.ts | Updates interface return type to ChatSessionChangedFile[]. |
Copilot's findings
- Files reviewed: 7/8 changed files
- Comments generated: 2
extensions/copilot/src/extension/chatSessions/vscode-node/chatSessionWorktreeServiceImpl.ts
Show resolved
Hide resolved
Yoyokrazy
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapplying this now that our d.ts files are in sync