Skip to content

Implementing user-scoped memory #309942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sneefyyy wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Implementing user-scoped memory #309942

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
a7ba3a7
porting changes from old vscode-copilot-chat repo
sneefyyy Apr 14, 2026
0c9fc89
fixing copilot recommendations
sneefyyy Apr 14, 2026
c536a83
Update extensions/copilot/src/extension/tools/node/agentMemoryToolReg…
sneefyyy Apr 16, 2026
2736d6d
fixing double /prompt fetch issue
sneefyyy Apr 16, 2026
8e90a50
removing local fallback that copilot created ...
sneefyyy Apr 16, 2026
3c56eb4
fixing file success message
sneefyyy Apr 16, 2026
0ec7fc8
integrating Audree's changes in agentic tools
sneefyyy Apr 16, 2026
675e520
fixing duplicate NWO
sneefyyy Apr 16, 2026
52a361e
fixing error message
sneefyyy Apr 16, 2026
d7ec29e
formatting issue
sneefyyy Apr 16, 2026
43ff4e1
removing voting as that isn't part of this PR
sneefyyy Apr 16, 2026
5ca4e09
fixing old comment
sneefyyy Apr 16, 2026
f70311c
inline citations
sneefyyy Apr 16, 2026
e067cc8
fixing version num of copilot-agentic-tools
sneefyyy Apr 17, 2026
3e82bd6
fixing error message
sneefyyy Apr 17, 2026
34f3d8b
merge
sneefyyy Apr 17, 2026
352a770
fixing comment
sneefyyy Apr 17, 2026
6deddab
fixing URL error
sneefyyy Apr 17, 2026
60cf1f5
repoNwo fixed
sneefyyy Apr 17, 2026
78eaf6e
fixing comment error
sneefyyy Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extensions/copilot/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6349,6 +6349,7 @@
"@anthropic-ai/sdk": "^0.82.0",
"@github/blackbird-external-ingest-utils": "^0.3.0",
"@github/copilot": "^1.0.24",
"@github/copilot-agentic-tools": "file:../../../copilot-agentic-tools",
Copy link
Copy Markdown
Collaborator

@bhavyaus bhavyaus Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is incorrect

Copy link
Copy Markdown
Author

@sneefyyy sneefyyy Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stand in, until Audree's PR is merged, I can remove it

Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding "@github/copilot-agentic-tools" as a file:../../../copilot-agentic-tools dependency points outside this repository, which will break clean installs/CI checkouts (the target directory isn't present here). It also leaves extensions/copilot/package-lock.json out of sync (no entry for this package). Please switch to a published/workspace-managed dependency that exists in CI (or vendor it into the repo) and update the lockfile accordingly.

Suggested change
"@github/copilot-agentic-tools": "file:../../../copilot-agentic-tools",
"@github/copilot-agentic-tools": "^1.0.0",

Copilot uses AI. Check for mistakes.
"@google/genai": "^1.22.0",
"@humanwhocodes/gitignore-to-minimatch": "1.0.2",
"@microsoft/tiktokenizer": "^1.0.10",
Expand Down
2 changes: 2 additions & 0 deletions extensions/copilot/src/extension/extension/vscode-node/services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ import { FixCookbookService, IFixCookbookService } from '../../prompts/node/inli
import { WorkspaceMutationManager } from '../../testing/node/setupTestsFileManager';
import { AgentMemoryService, IAgentMemoryService } from '../../tools/common/agentMemoryService';
import { IMemoryCleanupService, MemoryCleanupService } from '../../tools/common/memoryCleanupService';
import { AgentMemoryToolRegistrar, IAgentMemoryToolRegistrar } from '../../tools/node/agentMemoryToolRegistrar';
import { IToolDeferralService } from '../../../platform/networking/common/toolDeferralService';
import { ToolDeferralService } from '../../tools/common/toolDeferralService';
import { IToolsService } from '../../tools/common/toolsService';
Expand Down Expand Up @@ -168,6 +169,7 @@ export function registerServices(builder: IInstantiationServiceBuilder, extensio
builder.define(IToolsService, new SyncDescriptor(ToolsService));
builder.define(IToolDeferralService, new ToolDeferralService());
builder.define(IAgentMemoryService, new SyncDescriptor(AgentMemoryService));
builder.define(IAgentMemoryToolRegistrar, new SyncDescriptor(AgentMemoryToolRegistrar));
builder.define(IMemoryCleanupService, new SyncDescriptor(MemoryCleanupService));
builder.define(IChatDiskSessionResources, new SyncDescriptor(ChatDiskSessionResources));
builder.define(IRequestLogger, new SyncDescriptor(RequestLogger));
Expand Down
Loading
Loading