Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Git extension’s Copilot AI co-author trailer to use the new GitHub noreply email address, and aligns the unit test accordingly.
Changes:
- Updated the hardcoded Copilot co-author trailer email in repository logic.
- Updated the corresponding
parseCoAuthorstest expectation to match the new email.
Show a summary per file
| File | Description |
|---|---|
| extensions/git/src/repository.ts | Updates the constant used to append the Copilot co-author trailer. |
| extensions/git/src/test/git.test.ts | Updates the co-author parsing test to expect the new Copilot noreply email. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
| } | ||
|
|
||
| private static readonly AI_CO_AUTHOR_TRAILER = 'Co-authored-by: Copilot <copilot@github.com>'; | ||
| private static readonly AI_CO_AUTHOR_TRAILER = 'Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>'; |
There was a problem hiding this comment.
If appendAICoAuthorTrailer (or related logic) checks for an existing AI trailer by exact string match against AI_CO_AUTHOR_TRAILER, changing this value can cause duplicate trailers when a commit message already contains the old copilot@github.com trailer (e.g., after upgrading). Consider detecting the Copilot trailer via a stable pattern (e.g., matching Co-authored-by: Copilot <...>), or supporting both the old and new emails for presence checks/cleanup.
| parseCoAuthors('Fix bug\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>'), | ||
| [{ name: 'Copilot', email: '223556219+Copilot@users.noreply.github.com' }] |
There was a problem hiding this comment.
The new Copilot noreply email is now duplicated as a raw string in test code and in Repository.AI_CO_AUTHOR_TRAILER. To prevent future drift (e.g., if the email changes again), consider centralizing this value in a shared constant/module that both the repository logic and tests can reference, or have the test assert via the same source of truth used to build the trailer.
| parseCoAuthors('Fix bug\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>'), | |
| [{ name: 'Copilot', email: '223556219+Copilot@users.noreply.github.com' }] | |
| parseCoAuthors('Fix bug\n\nCo-authored-by: Copilot <copilot@example.com>'), | |
| [{ name: 'Copilot', email: 'copilot@example.com' }] |
Screenshot ChangesBase: Changed (3)
|
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
| assert.deepStrictEqual( | ||
| parseCoAuthors('Fix bug\n\nCo-authored-by: Copilot <copilot@github.com>'), | ||
| [{ name: 'Copilot', email: 'copilot@github.com' }] | ||
| parseCoAuthors('Fix bug\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>'), |
AI Co-author Email Update:
copilot@github.comto223556219+Copilot@users.noreply.github.comin both the repository logic and the corresponding test. [1] [2]