Generalize anchor layout for webviews#310030
Open
mjbvz wants to merge 3 commits intomicrosoft:mainfrom
Open
Conversation
Previously I only changed this for webview editors but it makes sense to do for other webview too
Contributor
There was a problem hiding this comment.
Pull request overview
This PR generalizes the CSS Anchor Positioning–based layout behavior from the webview editor implementation into the shared OverlayWebview so that all overlay-based webviews can benefit from automatic position tracking between explicit layout calls.
Changes:
- Removed the editor-specific CSS anchor positioning setup/cleanup from
WebviewEditor. - Added centralized CSS anchor positioning support to
OverlayWebview.layoutWebviewOverElement, with a pixel-position fallback when unsupported. - Added anchor cleanup on
OverlayWebview.release/disposeto avoid leaking anchor-related styles.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/webviewPanel/browser/webviewEditor.ts | Removes editor-local anchor positioning so layout behavior is owned by the shared overlay implementation. |
| src/vs/workbench/contrib/webview/browser/overlayWebview.ts | Implements anchor positioning in the shared overlay layout path and adds cleanup for anchor-related styles. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously I only changed this for webview editors but it makes sense to do for other webview too
This also updates the clipping to use anchor position so that the entire layout flow should be handled by browsers now
Fixes #130353