Skip to content

Added path filter to validate.yml#1242

Merged
jasonjoh merged 2 commits intodevfrom
jasonjoh/validation-path-filter
Aug 29, 2025
Merged

Added path filter to validate.yml#1242
jasonjoh merged 2 commits intodevfrom
jasonjoh/validation-path-filter

Conversation

@jasonjoh
Copy link
Copy Markdown
Member

So now the validation will only run if relevant files are changed. There's no reason to run validation on sample queries if only permissions files are changed, for example.

Also added an opposite-filtered version of the workflow in validate-patch.yml. This will allow us to make this a required status check on PRs without blocking PRs that don't touch relevant files. See https://github.com/orgs/community/discussions/44490 for context.

So now the validation will only run if relevant files are changed. There's no reason to run validation on sample queries if only permissions files are changed, for example.

Also added an opposite-filtered version of the workflow in validate-patch.yml. This will allow us to make this a required status check on PRs without blocking PRs that don't touch relevant files. See https://github.com/orgs/community/discussions/44490 for context.
Copilot AI review requested due to automatic review settings August 29, 2025 14:55
@jasonjoh jasonjoh requested a review from a team as a code owner August 29, 2025 14:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds path filtering to GitHub workflow validation to optimize CI runs by only executing validation when relevant files are modified. The solution addresses the issue where required status checks would block PRs that don't modify validation-relevant files.

  • Added path filters to validate.yml to run only when sample queries, scripts, tests, or package files change
  • Created validate-patch.yml as a complementary workflow that passes for PRs not touching relevant files
  • Implemented solution for GitHub's required status check limitation using paths-ignore pattern

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/validate.yml Added path filters to trigger validation only for relevant file changes
.github/workflows/validate-patch.yml Created complementary workflow that passes when validation files aren't modified

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/validate.yml Outdated
Comment thread .github/workflows/validate-patch.yml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jasonjoh jasonjoh enabled auto-merge (squash) August 29, 2025 15:09
@jasonjoh jasonjoh merged commit 547dc7d into dev Aug 29, 2025
4 checks passed
@jasonjoh jasonjoh deleted the jasonjoh/validation-path-filter branch August 29, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants