Skip to content

Weekly Permissions sync 2025-09-19#1273

Closed
marabooy wants to merge 1 commit intodevfrom
permissions-update/2025-09-19
Closed

Weekly Permissions sync 2025-09-19#1273
marabooy wants to merge 1 commit intodevfrom
permissions-update/2025-09-19

Conversation

@marabooy
Copy link
Copy Markdown
Contributor

Weekly Permissions sync 2025-09-19

@marabooy marabooy requested a review from a team as a code owner September 19, 2025 00:24
Copilot AI review requested due to automatic review settings September 19, 2025 00:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This is a weekly permissions sync that updates API endpoint permissions and provisioning information for Microsoft Graph services. The changes include adding new endpoints for device management and lifecycle workflows, along with modifying existing permissions for organization places.

  • Added new API endpoints for device management virtual endpoints and lifecycle workflows
  • Updated permissions configuration for organization places to remove Application scheme
  • Added new provisioning entries for delegated work permissions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
permissions/new/permissions.json Added new API endpoints and updated permission schemes for virtual endpoints, lifecycle workflows, and organization places
permissions/new/ProvisioningInfo.json Added new provisioning entries with delegated work scheme permissions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

"/devicemanagement/virtualendpoint/cloudpcs/{id}": "least=DelegatedWork,Application",
"/devicemanagement/virtualendpoint/cloudpcs/{id}/getcloudpcconnectivityhistory": "least=DelegatedWork,Application",
"/devicemanagement/virtualendpoint/cloudpcs/{id}/getCloudPcLaunchInfo": "least=DelegatedWork,Application",
"/devicemanagement/virtualEndpoint/cloudPcs/{id}/retrieveFrontlineCloudPcDetail": "least=DelegatedWork,Application",
Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL path uses inconsistent casing. 'virtualEndpoint' and 'cloudPcs' use camelCase while other similar paths in the same section use lowercase (e.g., 'virtualendpoint/cloudpcs'). This should match the existing pattern for consistency.

Suggested change
"/devicemanagement/virtualEndpoint/cloudPcs/{id}/retrieveFrontlineCloudPcDetail": "least=DelegatedWork,Application",
"/devicemanagement/virtualendpoint/cloudpcs/{id}/retrievefrontlinecloudpcdetail": "least=DelegatedWork,Application",

Copilot uses AI. Check for mistakes.
"/devicemanagement/virtualendpoint/cloudpcs/{id}": "",
"/devicemanagement/virtualendpoint/cloudpcs/{id}/getcloudpcconnectivityhistory": "",
"/devicemanagement/virtualendpoint/cloudpcs/{id}/getCloudPcLaunchInfo": "",
"/devicemanagement/virtualEndpoint/cloudPcs/{id}/retrieveFrontlineCloudPcDetail": "",
Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same casing inconsistency as above. The path should use lowercase 'virtualendpoint/cloudpcs' to match the existing API path conventions in this section.

Suggested change
"/devicemanagement/virtualEndpoint/cloudPcs/{id}/retrieveFrontlineCloudPcDetail": "",
"/devicemanagement/virtualendpoint/cloudpcs/{id}/retrievefrontlinecloudpcdetail": "",

Copilot uses AI. Check for mistakes.
@@ -12558,6 +12566,14 @@
"isHidden": true,
"isEnabled": true,
"resourceAppId": "00000003-0000-0000-c000-00000000000"
Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resourceAppId is missing the final '0' character. It should be '00000003-0000-0000-c000-000000000000' to match the standard Microsoft Graph resource app ID format used elsewhere in the file.

Copilot uses AI. Check for mistakes.
@jasonjoh jasonjoh closed this Sep 22, 2025
@jasonjoh jasonjoh deleted the permissions-update/2025-09-19 branch September 23, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants