Conversation
There was a problem hiding this comment.
Pull Request Overview
Weekly sync to update permissions configuration with new API endpoints and their associated permission mappings.
- Added new device management and lifecycle workflow API endpoints with appropriate permission schemes
- Introduced new conditional access VPN connectivity certificate management endpoints
- Updated existing permission configurations to reflect current API capabilities
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| permissions/new/permissions.json | Added new API endpoints for device management, lifecycle workflows, and conditional access with corresponding permission mappings |
| permissions/new/ProvisioningInfo.json | Added new permission entries for delegated work schemes with resource app IDs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "/devicemanagement/virtualendpoint/cloudpcs/{id}": "least=DelegatedWork,Application", | ||
| "/devicemanagement/virtualendpoint/cloudpcs/{id}/getcloudpcconnectivityhistory": "least=DelegatedWork,Application", | ||
| "/devicemanagement/virtualendpoint/cloudpcs/{id}/getCloudPcLaunchInfo": "least=DelegatedWork,Application", | ||
| "/devicemanagement/virtualEndpoint/cloudPcs/{id}/retrieveFrontlineCloudPcDetail": "least=DelegatedWork,Application", |
There was a problem hiding this comment.
Inconsistent casing in URL path. The path uses 'virtualEndpoint' and 'cloudPcs' with mixed camelCase, while other similar paths in the file use lowercase 'virtualendpoint' and 'cloudpcs'. This should be consistent with the existing pattern.
| "/devicemanagement/virtualEndpoint/cloudPcs/{id}/retrieveFrontlineCloudPcDetail": "least=DelegatedWork,Application", | |
| "/devicemanagement/virtualendpoint/cloudpcs/{id}/retrievefrontlinecloudpcdetail": "least=DelegatedWork,Application", |
| @@ -12558,6 +12566,14 @@ | |||
| "isHidden": true, | |||
| "isEnabled": true, | |||
| "resourceAppId": "00000003-0000-0000-c000-00000000000" | |||
There was a problem hiding this comment.
Missing digit in resourceAppId. The GUID should end with '000000000000' (12 zeros) but only has 11 zeros. This should be '00000003-0000-0000-c000-000000000000' to match the pattern used elsewhere in the file.
Weekly Permissions sync 2025-09-20