Skip to content

Weekly Permissions sync 2025-12-14 #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marabooy wants to merge 2 commits into from
Closed

Weekly Permissions sync 2025-12-14 #1379

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
028ca61
Weekly Permissions sync 2025-12-14
marabooy Dec 14, 2025
a924064
Merge branch 'master' into permissions-update/2025-12-14
jasonjoh Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions permissions/new/permissions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10849,6 +10849,81 @@
"ownerSecurityGroup": "DcsMsGraphSchemaAdmins"
}
},
"CopilotPackages.Read.All": {
"authorizationType": "oAuth2",
"schemes": {
"DelegatedWork": {
"adminDisplayName": "Read all packages information",
"adminDescription": "Allows the user to read the packages information",
Copy link

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description "Allows the user to read the packages information" is grammatically awkward. Consider using either "package information" (singular, more idiomatic) or "packages' information" (possessive plural) for better clarity and consistency with other permission descriptions.

Copilot uses AI. Check for mistakes.
"userDisplayName": "Read all packages information",
"userDescription": "Allows the app to read packages information.",
Copy link

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description "Allows the app to read packages information." is grammatically awkward. Consider using either "package information" (singular, more idiomatic) or "packages' information" (possessive plural) for better clarity and consistency with other permission descriptions.

Copilot uses AI. Check for mistakes.
"requiresAdminConsent": false,
"privilegeLevel": 3
},
"Application": {
"adminDisplayName": "Read all packages information",
"adminDescription": "Allows the app to read packages information without a signed-in user.",
Copy link

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description "Allows the app to read packages information without a signed-in user." is grammatically awkward. Consider using either "package information" (singular, more idiomatic) or "packages' information" (possessive plural) for better clarity and consistency with other permission descriptions.

Copilot uses AI. Check for mistakes.
"requiresAdminConsent": true,
"privilegeLevel": 4
}
},
"pathSets": [
{
"schemeKeys": [
"DelegatedWork",
"Application"
],
"methods": [
"GET"
],
"paths": {
"/copilot/admin/catalog/packages": "least=DelegatedWork,Application",
"/copilot/admin/catalog/packages/{packageId}": "least=DelegatedWork,Application"
}
}
],
"ownerInfo": {
"ownerSecurityGroup": "m365adminsvcdevteam"
}
},
"CopilotPackages.ReadWrite.All": {
"authorizationType": "oAuth2",
"schemes": {
"DelegatedWork": {
"adminDisplayName": "Read and update all packages information",
"adminDescription": "Allows the user to read and update the packages information",
Copy link

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description "Allows the user to read and update the packages information" is grammatically awkward. Consider using either "package information" (singular, more idiomatic) or "packages' information" (possessive plural) for better clarity and consistency with other permission descriptions.

Copilot uses AI. Check for mistakes.
"userDisplayName": "Read and update all packages information",
"userDescription": "Allows the app to read and update packages information.",
Copy link

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description "Allows the app to read and update packages information." is grammatically awkward. Consider using either "package information" (singular, more idiomatic) or "packages' information" (possessive plural) for better clarity and consistency with other permission descriptions.

Copilot uses AI. Check for mistakes.
"requiresAdminConsent": true,
"privilegeLevel": 3
},
"Application": {
"adminDisplayName": "Read and update all packages information",
"adminDescription": "Allows the app to read and update packages information without a signed-in user.",
Copy link

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description "Allows the app to read and update packages information without a signed-in user." is grammatically awkward. Consider using either "package information" (singular, more idiomatic) or "packages' information" (possessive plural) for better clarity and consistency with other permission descriptions.

Copilot uses AI. Check for mistakes.
"requiresAdminConsent": true,
"privilegeLevel": 4
}
},
"pathSets": [
{
"schemeKeys": [
"DelegatedWork",
"Application"
],
"methods": [
"GET",
"POST"
Comment on lines +10913 to +10915
Copy link

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CopilotPackages.ReadWrite.All permission claims to allow "read and update" operations but only specifies GET and POST methods. Typically, update operations in REST APIs use PATCH or PUT methods. Consider whether PATCH or PUT should be included in the methods array to properly support update operations, or if the permission description should be updated to clarify that only creation (POST) is supported alongside reading (GET).

Copilot uses AI. Check for mistakes.
],
"paths": {
"/copilot/admin/catalog/packages": "least=DelegatedWork,Application",
"/copilot/admin/catalog/packages/{packageId}": "least=DelegatedWork,Application"
}
}
],
"ownerInfo": {
"ownerSecurityGroup": "m365adminsvcdevteam"
}
},
"CopilotSettings-LimitedMode.Read": {
"authorizationType": "oAuth2",
"schemes": {
Expand Down
18 changes: 9 additions & 9 deletions permissions/new/provisioningInfo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3510,15 +3510,15 @@
],
"CopilotPackages.Read.All": [
{
"id": "",
"id": "a2dcfcb9-cbe8-4d42-812d-952e55cf7f3f",
"scheme": "DelegatedWork",
"environment": "public",
"isHidden": true,
"isEnabled": false,
"isHidden": false,
"isEnabled": true,
"resourceAppId": "59eca866-2f46-40b8-96ff-63f663121ef9"
},
{
"id": "",
"id": "72f0655d-6228-4ddc-8e1b-164973b9213b",
"scheme": "Application",
"environment": "public",
"isHidden": true,
Expand All @@ -3528,15 +3528,15 @@
],
"CopilotPackages.ReadWrite.All": [
{
"id": "",
"id": "e9c5fd18-ac15-43dd-9f5c-6f9611dd5604",
"scheme": "DelegatedWork",
"environment": "public",
"isHidden": true,
"isEnabled": false,
"isHidden": false,
"isEnabled": true,
"resourceAppId": "59eca866-2f46-40b8-96ff-63f663121ef9"
},
{
"id": "",
"id": "ed31732f-9495-47ed-ba3b-4ed0948c1c64",
"scheme": "Application",
"environment": "public",
"isHidden": true,
Expand Down Expand Up @@ -15972,7 +15972,7 @@
{
"id": "7ff9afdd-0cdb-439d-a61c-fea3e9339e89",
"scheme": "DelegatedWork",
"environment": "PPE;public",
"environment": "",
Copy link

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment field is being changed from "PPE;public" to an empty string for the DelegatedWork scheme, but the Application scheme on line 15983 retains "PPE;public". This creates an inconsistency within the same permission "User-OnPremisesSyncBehavior.ReadWrite.All" where the two schemes have different environment values. Consider whether both schemes should have the same environment value for consistency.

Suggested change
"environment": "",
"environment": "PPE;public",

Copilot uses AI. Check for mistakes.
"isHidden": false,
"isEnabled": true,
"resourceAppId": ""
Expand Down