Skip to content

Weekly Permissions sync 2026-04-24#1510

Open
marabooy wants to merge 3 commits intomasterfrom
permissions-update/2026-04-24
Open

Weekly Permissions sync 2026-04-24#1510
marabooy wants to merge 3 commits intomasterfrom
permissions-update/2026-04-24

Conversation

@marabooy
Copy link
Copy Markdown
Contributor

Weekly Permissions sync 2026-04-24

Copilot AI review requested due to automatic review settings April 24, 2026 00:27
@marabooy marabooy requested a review from a team as a code owner April 24, 2026 00:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Weekly permissions sync updating the permissions catalog and provisioning metadata, including enabling newly defined Agent Registration permissions and adding newly discovered API paths.

Changes:

  • Populate IDs and enable/unhide AgentRegistration.Read.All and AgentRegistration.ReadWrite.All in provisioningInfo.json.
  • Refine several permission descriptions/names and add new permission definitions for Agent Registration in permissions.json.
  • Add newly discovered report endpoints under existing permissions path mappings.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
permissions/new/provisioningInfo.json Sets concrete GUIDs and flips isEnabled/isHidden for AgentRegistration permissions so they can be provisioned/exposed.
permissions/new/permissions.json Adds AgentRegistration permission definitions, tweaks several admin descriptions/display names, and updates path mappings with new report endpoints.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +3113 to +3118
"adminDisplayName": "Read all agent registrations",
"adminDescription": "Allows the user to read all agent registration information",
"userDisplayName": "Read all agent registrations",
"userDescription": "Allows the app to read agent registration information.",
"requiresAdminConsent": false,
"privilegeLevel": 3
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the new AgentRegistration.Read.All delegated scheme, adminDescription says "Allows the user…" (and lacks a trailing period) while userDescription says "Allows the app…". Elsewhere in this file delegated permissions consistently describe the calling app/client (e.g., Agreement.Read.All at ~3222-3224). Consider aligning the wording (app/client vs user) and punctuation, and ensure the delegated descriptions clearly indicate "on behalf of the signed-in user" when applicable.

Copilot uses AI. Check for mistakes.
Comment on lines +3148 to +3153
"DelegatedWork": {
"adminDisplayName": "Read and write all agent registrations",
"adminDescription": "Allows the user to read and write all agent registration information",
"userDisplayName": "Read and write all agent registrations",
"userDescription": "Allows the app to read and write agent registration information.",
"requiresAdminConsent": true,
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly for AgentRegistration.ReadWrite.All delegated scheme, adminDescription uses "Allows the user…" (no period) while userDescription uses "Allows the app…". For consistency with other delegated permissions in this file, update the delegated descriptions to consistently refer to the calling app/client and end sentences with periods.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants