arm64: dts: qcom: msm8916-lenovo-phab: add device#289
arm64: dts: qcom: msm8916-lenovo-phab: add device#289oknyshuk wants to merge 5 commits intomsm8916-mainline:msm8916/6.2-rc5from
Conversation
Lenovo PHAB (PB1-750M) is a phablet using the MSM8916 SoC released in late 2015. Add a device tree for with initial support for: - GPIO keys - pm8916-vibrator - SDHCI (internal and external storage) - USB Device Mode - Charging - UART (not tested) - WCNSS (WiFi/BT) - Modem (LTE works, calls & SMS not tested) - Regulators - Sound (WIP) - Accelerometer (WIP) Signed-off-by: Oleksandr Knyshuk <kigen745@gmail.com>
Signed-off-by: Oleksandr Knyshuk <kigen745@gmail.com>
Add jdi_1080p display panel with pwm and backlight and FT5336 touchscreen with according pinctrls Signed-off-by: Oleksandr Knyshuk <kigen745@gmail.com>
oknyshuk
force-pushed
the
lenovo-phab
branch
from
8bf794d to
7d15c29
Compare
…r-generator X-Code-Generator: msm8916-mainline/linux-panel-drivers@22b5266 Signed-off-by: lmdpdg <lmdpdg@localhost>
|
|
||
| &pm8916_bms { | ||
| monitored-battery = <&battery>; | ||
| //power-supplies = <&charger>; |
There was a problem hiding this comment.
It doesn't seem to be used or required.
There was a problem hiding this comment.
It causes kernel panic, though it is the right way to use bms and charger together
| }; | ||
| }; | ||
|
|
||
| &blsp_i2c5 { |
There was a problem hiding this comment.
Unlike display panels, touchscreen can be upstreamed with the driver in Torvald's tree, so you might want to split it from the display panel commit.
There was a problem hiding this comment.
is there an easy way to do it?
There was a problem hiding this comment.
Not known yet, I assume. You need to do this during git rebase.
There was a problem hiding this comment.
- Delete touchscreen parts, and commit with message
blah blah - Revert commit, and reword the revert with message
arm64: dts: qcom: msm8916-lenovo-phab: add touchscreen - Squash/fixup
blah blah, and reword
There was a problem hiding this comment.
You can probably reset the commit during the rebase, then split into two with git add --patch to only add some hunks (not sure if it would be split nicely though) and then squash the resulting touchscreen commit into the first one using another interactive rebase. Otherwise can probably interactive rebase -> edit first commit to add the TS and then fix the merge conflict when this commit applies.
| } | ||
|
|
||
| static const struct of_device_id jdi_of_match[] = { | ||
| { .compatible = "lenovo,phab-jdi_1080p" }, // FIXME |
There was a problem hiding this comment.
| { .compatible = "lenovo,phab-jdi_1080p" }, // FIXME | |
| { .compatible = "lenovo,phab-jdi-1080p" }, // FIXME |
or
| { .compatible = "lenovo,phab-jdi_1080p" }, // FIXME | |
| { .compatible = "lenovo,phab-jdi" }, // FIXME |
You also need to fix it in msm8916-mainline/linux-panel-drivers#28 and generate the driver again.
There was a problem hiding this comment.
Only when you have defined lenovo,phab-panel in lk2nd and it selects from multiple panels.
msm8916-mainline/lk2nd@933fbc3
Anyway here is the naming rule, <vendor>,[device-]<panel_name>.
There was a problem hiding this comment.
<vendor>,[device-]<panel_name>.
I see panel_name, not panel-name
There was a problem hiding this comment.
Basically it's meant to be dashes instead of underscores for compatible entries, if you know what I mean.
Signed-off-by: Oleksandr Knyshuk <kigen745@gmail.com>
| smb_int_default: smb-int-default-state { | ||
| pins = "gpio62"; | ||
| function = "gpio"; | ||
|
|
There was a problem hiding this comment.
| } | ||
|
|
||
| static const struct of_device_id jdi_of_match[] = { | ||
| { .compatible = "lenovo,phab-jdi_1080p" }, // FIXME |
There was a problem hiding this comment.
Only when you have defined lenovo,phab-panel in lk2nd and it selects from multiple panels.
msm8916-mainline/lk2nd@933fbc3
Anyway here is the naming rule, <vendor>,[device-]<panel_name>.
| }; | ||
| }; | ||
|
|
||
| &blsp_i2c5 { |
There was a problem hiding this comment.
Not known yet, I assume. You need to do this during git rebase.
| dtb-$(CONFIG_ARCH_QCOM) += msm8916-gplus-fl8005a.dtb | ||
| dtb-$(CONFIG_ARCH_QCOM) += msm8916-huawei-g7.dtb | ||
| dtb-$(CONFIG_ARCH_QCOM) += msm8916-huawei-y635.dtb | ||
| dtb-$(CONFIG_ARCH_QCOM) += msm8916-lenovo-phab.dtb |
There was a problem hiding this comment.
Commit message: Please drop "not tested" :)
(you can do a reword with interactive rebase fyi)
| summit,enable-usb-charging; | ||
| summit,enable-mains-charging; |
There was a problem hiding this comment.
I'm not sure if you actually need both here... is "mains" required? and/or is there an example that uses mains that you have took this from? (I'd expect "mains" to mean "mains power" aka 220v or a barrel jack)
| }; | ||
| }; | ||
|
|
||
| &blsp_i2c5 { |
There was a problem hiding this comment.
You can probably reset the commit during the rebase, then split into two with git add --patch to only add some hunks (not sure if it would be split nicely though) and then squash the resulting touchscreen commit into the first one using another interactive rebase. Otherwise can probably interactive rebase -> edit first commit to add the TS and then fix the merge conflict when this commit applies.
| qcom,platform-enable-gpio = <&msmgpio 109 GPIO_ACTIVE_HIGH>; | ||
| qcom,platform-reset-gpio = <&msmgpio 25 GPIO_ACTIVE_HIGH>; |
There was a problem hiding this comment.
I don't think the dsi port schema has any gpios...
| &pronto { | ||
| status = "okay"; | ||
|
|
||
| iris { | ||
| compatible = "qcom,wcn3660b"; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
A note about new changes since 6.3+: 3244442
3 participants
Lenovo PHAB (PB1-750M) is a phablet using the
MSM8916 SoC released in late 2015.
Add a device tree with initial support for:
Signed-off-by: Oleksandr Knyshuk kigen745@gmail.com