Skip to content

fix(teams): use lighter probeCircles()#7857

Open
ArtificialOwl wants to merge 2 commits intomainfrom
fix/noid/switch-to-probecircles
Open

fix(teams): use lighter probeCircles()#7857
ArtificialOwl wants to merge 2 commits intomainfrom
fix/noid/switch-to-probecircles

Conversation

@ArtificialOwl
Copy link
Copy Markdown
Member

@ArtificialOwl ArtificialOwl commented Apr 16, 2026 •
edited
Loading

it is advice to use probeCircles() for this purpose, the backend will request a structured/cached version of data about memberships,
it also extract less data from database and provide a way to request extra data. (DataProbe)

@ArtificialOwl ArtificialOwl force-pushed the fix/noid/switch-to-probecircles branch from 69cb6a4 to dd69c70 Compare April 16, 2026 13:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96045 was 93102 (+3.16%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96045 was 93102 (+3.16%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

luka-nextcloud
luka-nextcloud requested changes Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@luka-nextcloud luka-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The static analysis issue can be fixed by stubbing method probeCircles in tests/stub.phpstub
  • The performance warning can be ignored since it is unrelated

@ArtificialOwl
fix(teams): use lighter probeCircles()
a1654e0 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/switch-to-probecircles branch from dd69c70 to a1654e0 Compare April 16, 2026 16:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 95984 was 93102 (+3.09%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@ArtificialOwl ArtificialOwl force-pushed the fix/noid/switch-to-probecircles branch from b658677 to 07c9be9 Compare April 16, 2026 16:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 95984 was 93102 (+3.09%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 95987 was 93102 (+3.09%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@ArtificialOwl ArtificialOwl force-pushed the fix/noid/switch-to-probecircles branch from 07c9be9 to 46ad0a3 Compare April 16, 2026 16:34
@ArtificialOwl
adding probeCircle/probeCircles
298f567 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/switch-to-probecircles branch from 46ad0a3 to 298f567 Compare April 16, 2026 16:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 95997 was 93102 (+3.1%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96002 was 93102 (+3.11%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@grnd-alt grnd-alt Awaiting requested review from grnd-alt grnd-alt is a code owner

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArtificialOwl @artonge @luka-nextcloud