Change new plugin installation location on Windows

Author: anjaldoshi

Source/MainWindow.cpp

@@ -30,13 +30,13 @@
 static inline File getSavedStateDirectory() {
 #if defined(__APPLE__)
     File dir = File::getSpecialLocation(File::userApplicationDataDirectory).getChildFile("Application Support/open-ephys");
-    if (!dir.isDirectory()) {
+#else
+    File dir = File::getSpecialLocation(File::commonApplicationDataDirectory).getChildFile("Open Ephys");
+#endif
+	if (!dir.isDirectory()) {
         dir.createDirectory();
     }
     return std::move(dir);
-#else
-    return File::getSpecialLocation(File::currentExecutableFile).getParentDirectory();
-#endif
 }
 
 	MainWindow::MainWindow(const File& fileToLoad)

Source/Processors/PluginManager/PluginManager.cpp

@@ -73,8 +73,18 @@ static void errorMsg(const char *file, int line, const char *msg) {
 PluginManager::PluginManager()
 {
 #ifdef WIN32
+	//Shared directory at the same level as executable
 	File sharedPath = File::getSpecialLocation(File::currentApplicationFile).getParentDirectory().getChildFile("shared");
 	SetDllDirectory(sharedPath.getFullPathName().toUTF8());
+
+	//Shared directory managed by Plugin Installer at C:/ProgramData
+	File installSharedPath = File::getSpecialLocation(File::commonApplicationDataDirectory).getChildFile("Open Ephys/shared");
+	if (!installSharedPath.isDirectory()) {
+        installSharedPath.createDirectory();
+    }
+
+	AddDllDirectory(installSharedPath.getFullPathName().toWideCharPointer());
+	SetDefaultDllDirectories(LOAD_LIBRARY_SEARCH_DEFAULT_DIRS);
 #endif
 }
 
@@ -92,11 +102,14 @@ void PluginManager::loadAllPlugins()
     paths.add(File::getSpecialLocation(File::userApplicationDataDirectory).getChildFile("Application Support/open-ephys/plugins"));
 #else
 	paths.add(File::getSpecialLocation(File::currentApplicationFile).getParentDirectory().getChildFile("plugins"));
+	paths.add(File::getSpecialLocation(File::commonApplicationDataDirectory).getChildFile("Open Ephys/plugins"));	
 #endif
 
     for (auto &pluginPath : paths) {
         if (!pluginPath.isDirectory()) {
-            std::cout << "Plugin path not found: " << pluginPath.getFullPathName() << std::endl;
+            std::cout << "Plugin path not found: " << pluginPath.getFullPathName() 
+					  << "\nCreating new plugins directory..." << std::endl;
+			pluginPath.createDirectory();
         } else {
             loadPlugins(pluginPath);
         }

Source/UI/PluginInstaller.cpp

@@ -40,13 +40,10 @@
 static inline File getPluginsLocationDirectory() {
 #if defined(__APPLE__)
     File dir = File::getSpecialLocation(File::userApplicationDataDirectory).getChildFile("Application Support/open-ephys");
-    if (!dir.isDirectory()) {
-        dir.createDirectory();
-    }
-    return std::move(dir);
 #else
-    return File::getSpecialLocation(File::currentExecutableFile).getParentDirectory();
+    File dir = File::getSpecialLocation(File::commonApplicationDataDirectory).getChildFile("Open Ephys");
 #endif
+    return std::move(dir);
 }
 
 static String osType;