mark the batchprocessor as deprecated#15046
mark the batchprocessor as deprecated#15046codeboten wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
This continues the work to deprecate the batch processor in favour of the exporter helper's batching capabilities. Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
atoulme
left a comment
There was a problem hiding this comment.
LGTM - no joke, it has been coming for a while
The date it was opened on is unfortunate |
songy23
left a comment
There was a problem hiding this comment.
cc @open-telemetry/collector-approvers
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15046 +/- ##
==========================================
- Coverage 91.22% 91.22% -0.01%
==========================================
Files 697 697
Lines 44627 44629 +2
==========================================
+ Hits 40710 40711 +1
- Misses 2773 2775 +2
+ Partials 1144 1143 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
note i'm not putting in the changelog to avoid merging this until we have enough approvals |
There was a problem hiding this comment.
I don't think we should deprecate it. The processor (or its v2 version if implemented) is still useful in some specific scenarios.
I propose we instead implement the fixes and also change the docs to explain that the exporter helper should be used in most scenarios, describing the use cases for this component (or rather of the new better version of it).
If we actually implement the improvements on the processor as some kind of a v2 version, then v1 could be deprecated.
|
I volunteered myself to write an RFC to describe the difficult transition problem we're facing here. I have not seen the proposal to support major-versioning of components referred to in #13583 (comment), but it sounds like a potential solution. |
|
See #15047 |
This continues the work to deprecate the batch processor in favour of the exporter helper's batching capabilities.
Part of #12022