fixed max child bounties count#578
Open
sudhi76 wants to merge 1 commit intoopen-web3-stack:masterfrom
Open
Conversation
Author
|
Hi @claude please review. |
Contributor
|
No issues found. |
rockbmb
requested changes
Mar 31, 2026
Collaborator
rockbmb
left a comment
rockbmb
left a comment
There was a problem hiding this comment.
Thanks for the PR! The fix hasn't made it to production runtimes yet, so we'll have to wait for that.
|
|
||
| // ===== SECTION 4: Verify the transaction fails with TooManyChildBounties error ===== | ||
|
|
||
| const ev = await extractExtrinsicFailedEvent(client) |
Collaborator
There was a problem hiding this comment.
This line is still failing in the CI checks; the fix from paritytech/polkadot-sdk#10713 hasn't yet made it to either Polkadot or Kusama.
| @@ -2149,20 +2149,19 @@ | |||
| // ===== SECTION 2: Set parent child bounties count to exceed maxActiveChildBountyCount ===== | |||
|
|
|||
| const maxActiveChildBountyCount = client.api.consts.childBounties.maxActiveChildBountyCount.toNumber() | |||
Collaborator
There was a problem hiding this comment.
Can you add a comment mentioning paritytech/polkadot-sdk#10713 ?
For future reference, as otherwise the fact that this problem occurred will be lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the workaround for the child bounties max count bug and updates the test to use the correct
maxActiveChildBountyCountvalue directly.Changes
greaterThanMaxActiveChildBountyCountvariable that unnecessarily incremented the max countmaxActiveChildBountyCount(not above it)Why This Matters
The child_bounties pallet had a bug where it didn't properly enforce the
maxActiveChildBountyCountconstraint. This workaround was added to test around that issue. Now that the underlying bug has been fixed in the child_bounties release, the test can be simplified to use the correct limit value.Related Issues
Fixes the TODO from the child_bounties create release fix.