Block SHA1 mechanism for FIPS 140-3:#145
Open
vkanjur wants to merge 1 commit intoopencryptoki:masterfrom
Open
Conversation
This commit removes SHA1 mechanism when FIPS 140-3 is active. Signed-off-by: Vishnudatha Kanjur <kanjur@ibm.com>
ifranzki
reviewed
May 7, 2026
| DES3_CBC_MAC, DES3_CMAC, ED25519_KEYGEN, ED25519_SIGN, ED25519_VERIFY, | ||
| ED448_KEYGEN, ED448_SIGN, ED448_VERIFY, X25519_KEYGEN, X25519_DERIVE, | ||
| X448_KEYGEN, X448_DERIVE, RSA_ME, RSA_CRT, SHA512_DRNG, -1, -1 }; | ||
| X448_KEYGEN, X448_DERIVE, RSA_ME, RSA_CRT, SHA512_DRNG, SHA1, -1, -1 }; |
Contributor
There was a problem hiding this comment.
Adding SHA1 here causes it to no longer be included in the mechanism list (ica_get_functionlist()), but it does not hinder anyone from using the ica_sha1() function.....
I checked how this is done for e.g. DES, and there the ica_des_xxx() functions have
#ifdef ICA_FIPS
if (fips)
return EACCES;
#endif /* ICA_FIPS */
at the top of the function body. So this block the function when fips is active.
Note that ica_sha1() has the following there:
#ifdef ICA_FIPS
if (fips >> 1)
return EACCES;
#endif /* ICA_FIPS */
This blocks the function only if the fips selftests have failed (note (fips) vs (fips >> 1)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes SHA1 mechanism when FIPS 140-3 is active.