Open
Conversation
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to add observability around rule performance by emitting Prometheus/Micrometer metrics for rule execution duration (and logging timing information), so slow-running rules can be identified.
Changes:
- Add a new
openhab.rule.durationtimer metric alongside the existing rule run counter. - Track rule RUNNING→IDLE transitions to measure execution duration per rule.
- Rename the event count metric from
event_counttoevent.count.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
bundles/org.openhab.core.io.monitor/.../RuleMetric.java |
Adds rule-duration timer metric and state tracking for RUNNING/IDLE transitions. |
bundles/org.openhab.core.io.monitor/.../EventCountMetric.java |
Renames the emitted event count metric. |
Comments suppressed due to low confidence (1)
bundles/org.openhab.core.io.monitor/src/main/java/org/openhab/core/io/monitor/internal/metrics/RuleMetric.java:39
- The class Javadoc says this implements a “gauge metric”, but the implementation now publishes a counter and a timer (duration). Please update the Javadoc to reflect the actual metrics emitted (including the new duration metric name), so users know what to expect.
* The {@link RuleMetric} class implements a gauge metric for rules RUNNING events (per rule)
*
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Metrics] Monitor rule execution duration
Description
With this you can monitor the execution duration of your rules, to see whats running slow.
This is added via metrics (prometheus).
The execution time is as well printed to the logs.