Skip to content

fix: clear stale Upgrading condition on upgrade re-trigger#349

Open
zmberg wants to merge 1 commit intoopenkruise:masterfrom
zmberg:fix-upgrade-condition
Open

fix: clear stale Upgrading condition on upgrade re-trigger#349
zmberg wants to merge 1 commit intoopenkruise:masterfrom
zmberg:fix-upgrade-condition

Conversation

@zmberg
Copy link
Copy Markdown
Member

@zmberg zmberg commented May 7, 2026

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: liheng <liheng.zms@alibaba-inc.com>
@kruise-bot kruise-bot requested review from AiRanthem and furykerry May 7, 2026 07:47
@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zmberg by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.12%. Comparing base (4a570c0) to head (9e83de8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   75.12%   75.12%           
=======================================
  Files         141      141           
  Lines        9850     9851    +1     
=======================================
+ Hits         7400     7401    +1     
  Misses       2141     2141           
  Partials      309      309           
Flag Coverage Δ
unittests 75.12% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants