adding orion consolidated analysis for 24, 120, 252 nodes#78671
adding orion consolidated analysis for 24, 120, 252 nodes#78671ArthurChenCoding wants to merge 6 commits intoopenshift:mainfrom
Conversation
WalkthroughAdds RUN_ORION environment settings and inserts the ChangesControl-plane Orion enablement (AWS nightly CI)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ArthurChenCoding The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Signed-off-by: ArthurChenCoding <artchen@redhat.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.23-nightly-x86.yaml`:
- Around line 137-143: For the three non-standard variant job configs
(control-plane-etcdencrypt-24nodes, control-plane-ipsec-120nodes,
control-plane-ipsec-252nodes) change their Orion gating so it’s deferred: set
RUN_ORION to "deferred" instead of "true" and remove or comment out the
'openshift-qe-orion-consolidated' entry from the test chain (the list under test
containing ref/chain entries) until Orion baselines are validated; update the
blocks referencing RUN_ORION and the test array for those specific job
definitions to reflect this gating.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 7d701534-b795-4a1e-8ca1-39698d5335ba
📒 Files selected for processing (4)
ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.21-nightly-x86.yamlci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.22-nightly-x86.yamlci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.23-nightly-x86.yamlci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-5.0-nightly-x86.yaml
Signed-off-by: ArthurChenCoding <artchen@redhat.com>
|
@ArthurChenCoding, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
| --local-indexing | ||
| NODE_DENSITY_GC: "false" | ||
| OPENSHIFT_INFRA_NODE_INSTANCE_TYPE: r5.4xlarge | ||
| RUN_ORION: "true" |
There was a problem hiding this comment.
I can see 4.21 6 node is deferred. But I'm not sure if 24-node and 120-node should also be deferred. for next step, Im checking if 4.21 have Orion baselines established for control-plane tests.
|
I will revert all the etcd and ispec ones |
|
/pj-rehearse |
|
@ArthurChenCoding: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Signed-off-by: ArthurChenCoding <artchen@redhat.com>
There was a problem hiding this comment.
♻️ Duplicate comments (1)
ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.23-nightly-x86.yaml (1)
130-144:⚠️ Potential issue | 🟠 Major | ⚡ Quick win
RUN_ORION: "true"+openshift-qe-orion-consolidatedstill present for non-standard variants — contradicts PR description.
control-plane-etcdencrypt-24nodes(line 137),control-plane-ipsec-120nodes(line 239), andcontrol-plane-ipsec-252nodes(line 265) still carryRUN_ORION: "true"and theopenshift-qe-orion-consolidatedchain. The PR description explicitly states these variants should useRUN_ORION: deferredwithout the consolidated chain, and the PR author stated an intent to revert these. Despite the prior review being marked "✅ Addressed", the current code still reflects the original (incorrect) state.These jobs use non-standard cluster configurations (OVN-IPsec / etcd-encryption) for which Orion baselines have not been confirmed. Running Orion with
"true"against missing baselines will produce systematic failures in the consolidated chain steps.Either apply the fix per the PR description, or revert the three jobs entirely:
🛠️ Option A: Apply deferred gating per PR description
# control-plane-etcdencrypt-24nodes (line 137) - RUN_ORION: "true" + RUN_ORION: deferred test: - ref: openshift-qe-workers-scale - chain: openshift-qe-control-plane - - chain: openshift-qe-orion-consolidated # control-plane-ipsec-120nodes (line 239) - RUN_ORION: "true" + RUN_ORION: deferred test: - ref: openshift-qe-workers-scale - chain: openshift-qe-control-plane - - chain: openshift-qe-orion-consolidated # control-plane-ipsec-252nodes (line 265) - RUN_ORION: "true" + RUN_ORION: deferred test: - ref: openshift-qe-workers-scale - chain: openshift-qe-control-plane - - chain: openshift-qe-orion-consolidatedAlso applies to: 226-250, 252-276
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.23-nightly-x86.yaml` around lines 130 - 144, The three job variants control-plane-etcdencrypt-24nodes, control-plane-ipsec-120nodes, and control-plane-ipsec-252nodes still enable Orion; update each job to match the PR intent by setting the env key RUN_ORION to "deferred" (replace RUN_ORION: "true") and remove the openshift-qe-orion-consolidated entry from the test chain (i.e., remove the ref/chain "openshift-qe-orion-consolidated" from the test list); alternatively, if you prefer the revert approach, restore the entire job definitions to their previous committed state instead of editing them. Ensure you modify the job blocks that include the env and test keys so the change applies to all listed occurrences.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In
`@ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.23-nightly-x86.yaml`:
- Around line 130-144: The three job variants control-plane-etcdencrypt-24nodes,
control-plane-ipsec-120nodes, and control-plane-ipsec-252nodes still enable
Orion; update each job to match the PR intent by setting the env key RUN_ORION
to "deferred" (replace RUN_ORION: "true") and remove the
openshift-qe-orion-consolidated entry from the test chain (i.e., remove the
ref/chain "openshift-qe-orion-consolidated" from the test list); alternatively,
if you prefer the revert approach, restore the entire job definitions to their
previous committed state instead of editing them. Ensure you modify the job
blocks that include the env and test keys so the change applies to all listed
occurrences.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 3b4842f4-89a1-4cf6-b357-e29554e28135
📒 Files selected for processing (2)
ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.21-nightly-x86.yamlci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.23-nightly-x86.yaml
Signed-off-by: ArthurChenCoding <artchen@redhat.com>
Signed-off-by: ArthurChenCoding <artchen@redhat.com>
Signed-off-by: ArthurChenCoding <artchen@redhat.com>
|
/pj-rehearse |
|
@ArthurChenCoding: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
@ArthurChenCoding: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
Enable Orion consolidated run for control-plane tests at 24, 120, and 252 node scales (we only have it for 6 nodes now)
Changes
Standard tests (10 total):
Tests Updated (10 total)
Tests Updated
Summary by CodeRabbit