[mdns] disable OT_MDNS explicitly when using platform mDNS#3230
[mdns] disable OT_MDNS explicitly when using platform mDNS#3230martinzi wants to merge 1 commit intoopenthread:mainfrom
Conversation
Summary of ChangesHello @martinzi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the mDNS configuration within the OpenThread Border Router (OTBR) build system. It ensures that OpenThread's internal mDNS implementation is explicitly turned off when the system is set up to utilize a platform-specific mDNS service, thereby avoiding redundant services and potential conflicts. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a small but important change to the CMake configuration. By explicitly setting OT_MDNS to OFF when a platform mDNS is being used, it prevents potential build issues caused by cached variables. This makes the build configuration more robust. The change is correct and well-targeted.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3230 +/- ##
===========================================
- Coverage 55.77% 34.75% -21.02%
===========================================
Files 87 145 +58
Lines 6890 17751 +10861
Branches 0 1470 +1470
===========================================
+ Hits 3843 6170 +2327
- Misses 3047 11256 +8209
- Partials 0 325 +325 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| set(OT_SRP_ADV_PROXY ON CACHE STRING "enable SRP Advertising Proxy" FORCE) | ||
| set(OT_TREL_MANAGE_DNSSD ON CACHE STRING "TREL to manage DNSSD and peer discovery" FORCE) | ||
| else() | ||
| set(OT_MDNS OFF CACHE STRING "disable OpenThread mDNS when using platform mDNS" FORCE) |
There was a problem hiding this comment.
This is fine to add, but by default it is also disabled in OT core.
There was a problem hiding this comment.
Agree, it is more a minor improvement preventing potential side effects in a development context.
2 participants
No description provided.