Skip to content

Remove outdated BOM warning from dependencyManagement #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codefromthecrypt merged 1 commit into from
Mar 25, 2026
Merged

Remove outdated BOM warning from dependencyManagement #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,16 +142,6 @@
<url>https://github.com/openzipkin/zipkin-reporter-java/issues</url>
</issueManagement>

<dependencyManagement>
<!-- Be careful here, especially to not import BOMs as io.zipkin.reporter2:zipkin-reporter and
zipkin-reporter-brave have this parent.

For example, if you imported Netty's BOM here, using Brave would also download that BOM as
it depends indirectly on io.zipkin.reporter2:zipkin-reporter-brave. As Brave itself is
indirectly used, this can be extremely confusing when people are troubleshooting library
version assignments. -->
</dependencyManagement>

<dependencies>
<!-- Do not add compile dependencies here. This can cause problems for libraries that depend on
io.zipkin.reporter2:zipkin-reporter or zipkin-reporter-brave difficult to unravel. -->
Expand Down
Loading