Skip to content

crash: port cd command#580

Open
shmsingh wants to merge 1 commit intoosandov:mainfrom
shmsingh:crash_command_cd
Open

crash: port cd command#580
shmsingh wants to merge 1 commit intoosandov:mainfrom
shmsingh:crash_command_cd

Conversation

@shmsingh
Copy link
Copy Markdown

@shmsingh shmsingh commented Dec 9, 2025

The cd command help to change the current working directory. It supports:

  • changing to a specified directory.
  • defaulting to $HOME when no path is provided.
  • if set cd - to switch to the previous directory.
  • Handle ~ and environment variable expansion.

@shmsingh shmsingh force-pushed the crash_command_cd branch 3 times, most recently from d7895fd to 924dd0b Compare December 9, 2025 17:35
@shmsingh
Copy link
Copy Markdown
Author

Please help reviewing the crash command cd support.

@shmsingh
Copy link
Copy Markdown
Author

shmsingh commented Jan 8, 2026

Please review the patch and share your feedback.

Copy link
Copy Markdown
Owner

@osandov osandov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, a few comments below.

Comment thread drgn/commands/_builtin/crash/_cd.py Outdated
Comment thread drgn/commands/_builtin/crash/_cd.py Outdated
Comment thread drgn/commands/_builtin/crash/_cd.py Outdated
Comment thread drgn/commands/_builtin/crash/_cd.py Outdated
Comment thread drgn/commands/_builtin/crash/_cd.py Outdated
@shmsingh
Copy link
Copy Markdown
Author

shmsingh commented Feb 4, 2026

Hi @osandov, sorry for the late response. I am on vacation. I will address the comments once I am back. Thanks.

…rts:

changing to a specified directory.
defaulting to $HOME when no path is provided.
if set cd - to switch to the previous directory.
Handle ~ and environment variable expansion.

Signed-off-by: Shminderjit Singh <shminderjit.singh@oracle.com>
@shmsingh
Copy link
Copy Markdown
Author

A gentle reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants